On Mon, Jul 6, 2015 at 10:59 AM, Fabio Estevam <[email protected]> wrote:
> On Mon, Jul 6, 2015 at 10:44 AM, Daiane Angolini
> <[email protected]> wrote:
>> Set the default value for IMAGE_BOOTLOADER explicitly instead of override it 
>> to
>> be clean.
>
> I would put it like this:
>
> "Set the default value for IMAGE_BOOTLOADER explicitly even though
> when user copies a .sdcard to the eMMC the bootloader will not be
> updated."

It is more than that, I think. Instead of removing the
IMAGE_BOOTLOADER ?= "" making warp to use the BSP default, I stated
the BSP default again in the conf file.

The consequence is, in case BSP default changes in future, warp will
not follow that.

I agree your sentence is better, but could you, please, let me know if
you agree with the change in source code as well?

This way I can prepare v2.

Thanks
Daiane
>
>>
>> WaRP use eMMC boot partition by default and the u-boot inside .sdcard image
>
> s/use/uses
>
>> does not override it. However, building u-boot binary anyway in order to 
>> provide
>> a binary to be used if an update is needed see how-to override eMMC boot
>> partition on the following link
>>  http://git.denx.de/?p=u-boot.git;a=blob;f=board/warp/README
>>
>> It is only changed back to default value to ease u-boot manual update for the
>> user.
>>
>> Signed-off-by: Daiane Angolini <[email protected]>
>
> Other than that:
>
> Reviewed-by: Fabio Estevam <[email protected]>
> --
> _______________________________________________
> meta-freescale mailing list
> [email protected]
> https://lists.yoctoproject.org/listinfo/meta-freescale
-- 
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Reply via email to