Thanks. I see one small additional change for 
meta-fsl-demos/recipes-graphics/fsl-gpu-sdk/fsl-gpu-sdk_2.1.bb:

-DEPENDS = "${X11_DEPENDS} ${WL_DEPENDS} ${DFB_DEPENDS}"
+DEPENDS = "${X11_DEPENDS} ${WL_DEPENDS}"

Tom

-----Original Message-----
From: Otavio Salvador [mailto:[email protected]] 
Sent: Thursday, October 29, 2015 3:14 PM
To: Hochstein Tom-R60874 <[email protected]>
Cc: Otavio Salvador <[email protected]>; meta-freescale Mailing List 
<[email protected]>; Sundararaj Prabhu-B36876 
<[email protected]>
Subject: Re: [meta-freescale] [meta-fsl-arm PATCH] Remove DirectFB support for 
i.MX6

On Thu, Oct 29, 2015 at 5:20 PM, Tom Hochstein <[email protected]> 
wrote:
> Hi Otavio,
>
> I think there are two problems with the patch.
>
> 1. In cairo_%.bbappend, you ended up removing -DEGL_API_FB from the 
> framebuffer build with the following change:
>
> +                                                      '-DEGL_API_FB 
> -DEGL_API_WL',  '', d), d)}"
>
> I believe the change should be this:
>
> +                                                      '-DEGL_API_FB 
> -DEGL_API_WL',  '-DEGL_API_FB', d), d)}"
>
> 2. In imx-gpu-viv.inc, you should also remove this line:
>
> -       libvivante-dfb-mx6 \

Thanks for the review. I reworked the patch per your suggestions.

I also pushed it to master-next for testing, together with the meta-fsl-demos 
rework as well. Please take a look there and let me know about any issues you 
find.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
-- 
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Reply via email to