Oh, and just to be clear, this proposal is a bugfix, not just a simplification. The design as it was would not allow the user to change the kernel config with an incremental build.
Tom -----Original Message----- From: Hochstein Tom-R60874 Sent: Wednesday, December 09, 2015 6:45 PM To: 'Otavio Salvador' <[email protected]> Cc: [email protected] Subject: RE: [meta-freescale] [meta-fsl-arm][PATCH] fsl-vivante-kernel-driver-handler.bbclass: Fix kernel config when graphics kernel module config is changed Hi Otavio, By 'in source defconfig', do you mean one in the recipe, as is done for linux-fslc? The fix does in fact already work for this case. I was actually working with linux-fslc when I discovered the bug. Also, since kernel.bbclass processes the .config in do_configure, don't we have to use _prepend? KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} oldnoconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig" kernel_do_configure() { ... eval ${KERNEL_CONFIG_COMMAND} } Tom -----Original Message----- From: Otavio Salvador [mailto:[email protected]] Sent: Thursday, November 26, 2015 5:38 AM To: Hochstein Tom-R60874 <[email protected]> Cc: [email protected] Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] fsl-vivante-kernel-driver-handler.bbclass: Fix kernel config when graphics kernel module config is changed On Wed, Nov 25, 2015 at 8:06 PM, Tom Hochstein <[email protected]> wrote: > Changes to the kernel config can only be applied to the defconfig > since the do_configure_prepend in fsl-kernel-localversion.bbclass > throws away the build/.config file. > > Signed-off-by: Tom Hochstein <[email protected]> I agree it can be simplified, but the prepend use here is what we ought to change. We should use _append so if someone uses the in source defconfig it will also work. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
