On 07/04/2017 22:14, Otavio Salvador wrote:

(...)
>
> Instead, adding LDFLAGS on the CC should fix the real error.
>

That's a better idea indeed. Attached patch fixes the protocol typo and
fixes the Makefile to resolve the QA issue detected.

Cheers,

Bas.

- Fix typo in download protocol (found by Joel Esponde)
- Fixed QA issue below by adding LDFLAGS (as suggested by Otavio Salvador)

ERROR: imx-uuc-0.5.1+gitAUTOINC+3440b11083-r1 do_package_qa: QA Issue: No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/uuc'
No GNU_HASH in the elf binary: '/work/build/tmp/work/bvd3_imx7d-poky-linux-gnueabi/imx-uuc/0.5.1+gitAUTOINC+3440b11083-r1/packages-split/imx-uuc/usr/bin/sdimage' [ldflags]

Found-by: Joel Esponde <joel.espo...@honeywell.com>
Signed-off-by: Bas Mevissen <bas.mevis...@emcodev.nl>
diff --git a/recipes-bsp/imx-uuc/imx-uuc/add-ldflags.patch b/recipes-bsp/imx-uuc/imx-uuc/add-ldflags.patch
new file mode 100644
index 0000000..ee46446
--- /dev/null
+++ b/recipes-bsp/imx-uuc/imx-uuc/add-ldflags.patch
@@ -0,0 +1,17 @@
+diff --git a/Makefile b/Makefile
+index df19c9f..384035b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -5,10 +5,10 @@ BINDIR ?= /usr/bin
+ all: uuc sdimage
+ 
+ uuc: uu.c
+-	$(CC)  uu.c -o uuc -lpthread
++	$(CC) uu.c -o uuc $(LDFLAGS) -lpthread
+ 
+ sdimage: sdimage.c
+-	$(CC) sdimage.c -o sdimage
++	$(CC) sdimage.c -o sdimage $(LDFLAGS)
+ 
+ install:
+ 	install -d $(DESTDIR)$(BINDIR)
diff --git a/recipes-bsp/imx-uuc/imx-uuc_git.bb b/recipes-bsp/imx-uuc/imx-uuc_git.bb
index 6fb838a..f99e81b 100644
--- a/recipes-bsp/imx-uuc/imx-uuc_git.bb
+++ b/recipes-bsp/imx-uuc/imx-uuc_git.bb
@@ -11,7 +11,9 @@ inherit autotools-brokensep
 PR = "r1"
 PV = "0.5.1+git${SRCPV}"
 
-SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocal=https"
+SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocol=https \
+           file://add-ldflags.patch"
+
 SRCREV = "3440b1108373e79669cc17ba1d2be91a123a2053"
 
 S = "${WORKDIR}/git"
-- 
_______________________________________________
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Reply via email to