Hi Otavio, Tom, Glad to see this series reaching the mailing list.
I have a few comments. First the title only mentions i.MX8M whereas the patch seems to also add i.MX8M Mini support, it'd be clearer to state both in the title. On Mon, Jun 25, 2018 at 04:30:29PM -0300, Otavio Salvador wrote: > From: Tom Hochstein <[email protected]> > > Signed-off-by: Tom Hochstein <[email protected]> > Signed-off-by: Otavio Salvador <[email protected]> > --- > > conf/machine/include/imx-base.inc | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/conf/machine/include/imx-base.inc > b/conf/machine/include/imx-base.inc > index 419ab1bc..346d1c77 100644 > --- a/conf/machine/include/imx-base.inc > +++ b/conf/machine/include/imx-base.inc > @@ -30,9 +30,10 @@ UBOOT_ENTRYPOINT_mx7 = "0x80008000" > UBOOT_ENTRYPOINT_vf = "0x80008000" > > PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg" > -XSERVER_DRIVER = "xf86-video-fbdev" > -XSERVER_DRIVER_imxgpu2d = "xf86-video-imx-vivante" > -XSERVER_DRIVER_vf = "xf86-video-modesetting" > +XSERVER_DRIVER = "xf86-video-fbdev" > +XSERVER_DRIVER_imxgpu2d = "xf86-video-imx-vivante" > +XSERVER_DRIVER_vf = "xf86-video-modesetting" > +XSERVER_DRIVER_append_mx8 = " xf86-video-modesetting" > XSERVER_DRIVER_use-mainline-bsp = "xf86-video-armada" > XSERVER = "xserver-xorg \ > xf86-input-evdev \ > @@ -52,6 +53,7 @@ DEFAULTTUNE_mx6 ?= "cortexa9thf-neon" > DEFAULTTUNE_mx6ul ?= "cortexa7thf-neon" > DEFAULTTUNE_mx6ull ?= "cortexa7thf-neon" > DEFAULTTUNE_mx7 ?= "cortexa7thf-neon" > +DEFAULTTUNE_mx8 ?= "aarch64" > DEFAULTTUNE_vf ?= "cortexa5thf-neon" > > INHERIT += "machine-overrides-extender" > @@ -66,6 +68,8 @@ MACHINEOVERRIDES_EXTENDER_mx6ul = "imxpxp" > MACHINEOVERRIDES_EXTENDER_mx6ull = "imxpxp:imxepdc" > MACHINEOVERRIDES_EXTENDER_mx7d = "imxpxp:imxepdc" > MACHINEOVERRIDES_EXTENDER_mx7ulp = "imxpxp:imxgpu2d:imxgpu3d" > +MACHINEOVERRIDES_EXTENDER_mx8mq = "imxvpu:imxgpu3d" > +MACHINEOVERRIDES_EXTENDER_mx8mm = "imxvpu:imxgpu2d:imxgpu3d" > > MACHINEOVERRIDES_EXTENDER_FILTER_OUT_use-mainline-bsp = " \ > mx6 \ > @@ -97,6 +101,8 @@ MACHINE_SOCARCH_SUFFIX_vf60 = "-vf60" > MACHINE_SOCARCH_SUFFIX_vf50 = "-vf50" > MACHINE_SOCARCH_SUFFIX_mx6ul = "-mx6ul" > MACHINE_SOCARCH_SUFFIX_mx6ull = "-mx6ul" > +MACHINE_SOCARCH_SUFFIX_mx8mm = "-mx8mm" > +MACHINE_SOCARCH_SUFFIX_mx8mq = "-mx8m" > MACHINE_SOCARCH_SUFFIX_use-mainline-bsp = "-imx" > > MACHINE_ARCH_FILTER = "virtual/kernel" > @@ -158,6 +164,7 @@ MACHINE_FIRMWARE_append_mx6sll = " firmware-imx-epdc" > MACHINE_FIRMWARE_append_mx6ull = " firmware-imx-epdc" > MACHINE_FIRMWARE_append_mx53 = " firmware-imx-vpu-imx53 > firmware-imx-sdma-imx53" > MACHINE_FIRMWARE_append_mx51 = " firmware-imx-vpu-imx51 > firmware-imx-sdma-imx51" > +MACHINE_FIRMWARE_append_mx8 = " linux-firmware-ath10k" Shouldn't this be board specific? Yes the EVK requires ath10k driver but it's not a CPU requirement. Regards, Gary -- _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
