Hi Toshiki, Thank you for the recipe. I have a few comments.
On Wed, 2020-08-12 at 16:03 +0900, Nishioka, Toshiki wrote: > the recipe installs the Slim Bootloader host tools which can generate > the container images to boot OS with Slim Bootloader. > > Signed-off-by: "Yong, Jonathan" <[email protected]> > Signed-off-by: "Nishioka, Toshiki" <[email protected]> > --- > recipes-bsp/iasimage/slimboot-tools_git.bb | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 recipes-bsp/iasimage/slimboot-tools_git.bb > > diff --git a/recipes-bsp/iasimage/slimboot-tools_git.bb b/recipes- > bsp/iasimage/slimboot-tools_git.bb > new file mode 100644 > index 00000000..bcb43816 > --- /dev/null > +++ b/recipes-bsp/iasimage/slimboot-tools_git.bb Can you please move this recipe to: dynamic-layers/meta-python/recipes-devtools/slimboot in meta-intel since we don't depend on meta-python and this recipe should be visible only when python layer is included. Before that, please check additional comments below. > @@ -0,0 +1,20 @@ > +DESCRIPTION = "Slim Bootloader is an open-source boot firmware > solution" This recipe is not building slim bootloader. Can you please modify this to describe what this recipe is providing? Please also add a SUMMARY. > +SRC_URI = > "git://github.com/slimbootloader/slimbootloader;protocol=https" > +SRCREV = "9f146afd47e0ca204521826a583d55388850b216" > +PV = "0.0.0+git${SRCPV}" > +LICENSE = "BSD-2-Clause-Patent" > +LIC_FILES_CHKSUM = > "file://LICENSE;md5=d1ed89007e7aa232a4dc1c59b6c9efc4" > +S = "${WORKDIR}/git" > +inherit python3native > +DEPENDS += "${PYTHON_PN}-cryptography ${PYTHON_PN}-idna" > +RDEPENDS_${PN} += "${PYTHON_PN}-cryptography ${PYTHON_PN}-idna" Are these two really needed? I can't find any references in the scripts being installed ... Did you mean python3-crypt? > +BBCLASSEXTEND = "native" > + > +do_configure[noexec] = "1" > +do_compile[noexec] = "1" > +do_install() { > + install -m 755 -d ${D}${libexecdir}/slimboot/Tools > + install -m 755 ${S}/BootloaderCorePkg/Tools/*.py > ${D}${libexecdir}/slimboot/Tools > +} > + > +FILES_${PN} = "${libexecdir}" This is default so is not needed. Thanks, Anuj
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6653): https://lists.yoctoproject.org/g/meta-intel/message/6653 Mute This Topic: https://lists.yoctoproject.org/mt/76142743/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-intel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
