Hi Chang Ching Thank you for the recipe. I have some comments:
On Wed, 2021-05-05 at 16:25 +0800, Yew, Chang Ching wrote: > ... > +RECIPE_MAINTAINER_pn-onevpl-intel-gpu = "Yew Chang Ching < > [email protected]>" Please add this in alphabetical order. > RECIPE_MAINTAINER_pn-backport-iwlwifi = "Naveen Saini < > [email protected]>" > RECIPE_MAINTAINER_pn-core-image-rt = "Anuj Mittal < > [email protected]>" > RECIPE_MAINTAINER_pn-core-image-rt-sdk = "Anuj Mittal < > [email protected]>" > diff --git a/recipes-multimedia/onevpl-intel-gpu/onevpl-intel- > gpu_2021.2.3.bb b/recipes-multimedia/onevpl-intel-gpu/onevpl-intel- > gpu_2021.2.3.bb > new file mode 100755 > index 00000000..cecdba77 > --- /dev/null > +++ b/recipes-multimedia/onevpl-intel-gpu/onevpl-intel- > gpu_2021.2.3.bb > @@ -0,0 +1,30 @@ > +SUMMARY = "Intel(R) oneVPL runtime for Intel GPU accelerated media > processing" > +DESCRIPTION = "Intel(R) oneVPL runtime provides an runtime to access > hardware-accelerated \ > +video decode, encode and filtering on Intel® graphics." > + > +HOMEPAGE = "https://github.com/oneapi-src/oneVPL-intel-gpu"; > +BUGTRACKER = "https://github.com/oneapi-src/oneVPL-intel-gpu/issues"; > + > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = " > file://LICENSE;md5=eb8cb45b9b57dbaa9fcc9adc4230202b" > +CVE_DETAILS = "intel:onevpl-intel-gpu" This is not needed. There is no such product as onevpl-intel-gpu listed as of now. This is needed only when the product name against which CVEs are filed is different from the recipe name. Also the correct variable to use is CVE_PRODUCT. The MediaSDK recipe also is using the wrong name so I will fix it. > + > +# Only for 64 bit > +COMPATIBLE_HOST = '(x86_64).*-linux' > +COMPATIBLE_HOST_x86-x32 = "null" > + > +DEPENDS += "libdrm libva intel-media-driver" > + > +SRC_URI = "git://github.com/oneapi-src/oneVPL-intel- > gpu.git;protocol=https;branch=main \ > + " > + > +SRCREV = "d6b0df4f058166cff31a360b77774f7410667be5" > +S = "${WORKDIR}/git" > + > +inherit cmake > + > +EXTRA_OECMAKE += "-DAPI=2.3" Why is this needed? It looks like 2.3 is the default if API is not passed? > + > +FILES_${PN} += " \ > + ${libdir}/* \ > + " > This is default behaviour and should not be needed to be explicitly specified here. Thanks, Anuj
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#7022): https://lists.yoctoproject.org/g/meta-intel/message/7022 Mute This Topic: https://lists.yoctoproject.org/mt/82599704/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-intel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
