> -----Original Message----- > From: Hart, Darren > Sent: Friday, July 18, 2014 10:37 AM > To: Kamble, Nitin A; Zanussi, Tom; [email protected]; > Burton, Ross > Cc: [email protected] > Subject: Re: [PATCH 1/1] image-ucode.bbclass: add dependency on the > microcode cpio provider > > On 7/18/14, 9:55, "Kamble, Nitin A" <[email protected]> wrote: > > >From: Nitin A Kamble <[email protected]> > > > >The ${EARLY_UCODE_CPIO} file is generated by the intel-microcode recipe. > >Even > >though the intel-microcode recipe is included for every Intel BSP, > >mention it here additionally as it won't hurt anything, and it can > >reveal the dependency to the reviewer easily. > > > >Signed-off-by: Nitin A Kamble <[email protected]> > >--- > > classes/image-ucode.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/classes/image-ucode.bbclass b/classes/image-ucode.bbclass > >index a0a3240..93ac28e 100644 > >--- a/classes/image-ucode.bbclass > >+++ b/classes/image-ucode.bbclass > >@@ -11,7 +11,7 @@ > > IMAGE_TYPES += "cpio.gz.ucode" > > COMPRESSIONTYPES += "gz.ucode" > > COMPRESS_CMD_gz.ucode = "${COMPRESS_CMD_gz}; cat > ${EARLY_UCODE_CPIO} > >${IMAGE_NAME}.rootfs.${type}.gz > > ${IMAGE_NAME}.rootfs.${type}.gz.ucode" > >-COMPRESS_DEPENDS_gz.ucode = "${COMPRESS_DEPENDS_gz}" > >+COMPRESS_DEPENDS_gz.ucode = "${COMPRESS_DEPENDS_gz} intel- > microcode" > > > > # Extentions to image-live.bbclass > > EARLY_UCODE_CPIO ?= "${DEPLOY_DIR_IMAGE}/microcode.cpio" > >-- > >1.8.1.4 > > > > > > > OK, but this should just be done as part of 5/7 of the previous series which > hasn't been merged yet. Can you include it and update your contrib branch? > No need to resend. I'll then review for any pending comments and pull. > Merged the two commits on the contrib branch.
> One thing I don't think I've seen discussed is the level of testing this has > received. Maybe I missed it? In any case - what level of testing has this > received? As the last commit was only for dependency addition, I did some build testing to ensure it does not cause any build breakages. Thanks, Nitin > > -- > Darren Hart Open Source Technology > Center > [email protected] Intel Corporation > -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
