> >> > >> Thanks for the patch Lim Siew Hoon, > >> > >> As a rule, I want to see some commit message with any patch, even an > >> upgrade. There is always something you can say to clarify, build > >> context, or improve confidence that this is a correct and tested fix. > > > > [Siew Hoon] Hi Darren, > > To upgrade the Intel-VA driver to 1.6.0, it also needs to upgrade together > with Libva 1.6.0. > > It is because Intel-VA driver got dependency with VA-API version 0.38, this > VA-API version only bump in libva1.6.0 version. > > And gstreamer-vaapi 0.6.0 with right now got a lot of fixed. > > Right now yocto using 0.5.10 -> 0.6.0 version (this is version going to use > together with libva, intel-va driver 1.6.0 version). > > > > Test with Braswell plaform will be it good enough cover the confidence level > to accept the new upgrade? > > > >> > >> Something about this being part of a larger upgrade to 1.6 > >> libva-intel-driver and 0.6 gstreamer, that it's been tested together > >> - on which platforms? Does this fix a particular issue you were > >> facing? Do you need it for a specific platform only supported in this > >> version? > etc. > > > > [Siew Hoon] > > The larger upgrade is target for Gen9 platform supported. > > Yes, and it is also for specific platform for Gen9 got 1 patch which I > > didn't > include at here because it is not been upstream yet. > > > > That is the kind of context I'm looking for in the commit messages, yes. > This becomes part of the permanent git history, so people looking to > understand why changes were made or how bugs were introduced, will > understand the motivation behind each change.. Please resubmit with this > information and the update recommended by Ross.
Hi Darren, Ok, noted. I will do include that information and test result inside the commit as well and also include on update recommended by Ross. Thanks for the feedback. ...siewhoon > > -- > Darren Hart > Intel Open Source Technology Center -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
