On Mon, Aug 10, 2015 at 02:06:09PM +0200, Andrea Galbusera wrote: > Hi Brendan, > > On Mon, Aug 10, 2015 at 1:05 PM, Brendan Le Foll > <[email protected]> wrote: > > On Fri, Aug 07, 2015 at 03:15:33PM +0100, Andrea Galbusera wrote: > >> * upgrade previous patch to avoid wiping CFLAGS. This fixes build on arm > >> platforms which previously caused an issue due to -fPIC being lost > >> > >> Signed-off-by: Andrea Galbusera <[email protected]> > >> --- > >> Note: I'm re-sending this beacuse initially sent to the list as a > >> non-member. > >> > >> This patch is inteded to fix a build error when building on arm > >> platforms. To reproduce the issue just bitbake hiredis for the Yocto > >> arm reference machine beaglebone. > >> > >> The error comes from the -fPIC compiler option being lost due to the > >> current version of 0001-Makefile-remove-hardcoding-of-CC.patch which > >> does not honor CFLAGS from the environment. > >> > >> The proposed patch is a minimal variation of the current version that > >> fixes the issue both on a cortexa5 target and the beaglebone. > >> > >> The patch was also successfully build tested against qemuarm and qemux86. > >> > >> Also available on GitHub at: > >> https://github.com/gizero/meta-intel-iot-middleware/tree/hiredis-fix-arm-build > > > > Thanks for submitting it's merged on master, I've been on vacation > > hence the delay :) > > FYI, this cleanly applies to dizzy branch also (where it was actually > developed and tested). I don't know what the layer's policy is for > backporting fixes to release branches... Also, I have another patch > that simplifies and cleans up the same hiredis recipe (probably more > suitable for a merge on master only) that I will submit as soon as it > goes through enough testing.
There's no explicit policy, if it's useful to you and doesn't break my use then I'm happy to merge it :) Just mention you want it backported to dizzy in a cover mail or something and I will. I've cherry picked it into dizzy. I look forward to your future patches! Cheers, Brendan -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
