On Wed, 2017-03-22 at 09:49 +0200, Mikko Ylinen wrote: > > On 21/03/17 20:08, Wold, Saul wrote: > > > > On Tue, 2017-03-21 at 11:39 +0200, Jussi Laako wrote: > > > > > > On 21.03.2017 01:59, Cal Sullivan wrote: > > > > > > > > The addition of kernel-modules is going to greatly increase the > > > > size of > > > > -minimal images for intel-corei7-64 and intel-core2-32, as > > > > these > > > > configurations build a lot of modules. I think it would be best > > > > to > > > > leave > > > > this one in only intel-quark. > > > On the other hand, then lot of hardware won't work, because > > > drivers > > > are > > > built as modules... Pretty much only boot-critical drivers should > > > be > > > built into the kernel. I find it especially strange if we have > > > linux-firmware installed but not modules, because most of the > > > firmwares > > > are used by modules (WiFi drivers, etc). So if kernel-modules is > > > removed > > > then also linux-firmware should be removed, that is another large > > > package and not boot-critical. > > This package is about 900K > > linux-firmware PKGSIZE according to pkgdata is ~86M. > > > > > > > > > > > IMO, there are better places to shave off size of minimal images > > > than > > > cutting out hardware support. > > > > > You realize that core-image-minimal goes from 8.7M -> 59M by adding > > the > > modules, so there is not other place to shave off size in the > > minimal > > image. > > MACHINE_EXTRA_RRECOMMENDS does not affect core-image-minimal > (MACHINE_ESSENTIAL_* do). > > > > > > > 40M is in /lib > > 6.8M in /boot > > > > I think this is a case where the RefKit includes modules but it > > does > > not go into meta-intel, this is more of a Distro/Image level choice > > than a BSP level choice. So this is not a customer BSP in refkit. > > > > > > The patch tries to make MACHINE_EXTRA_RRECOMMENDS setting more > consistent > accross intel-* machines. Jussi has a good point that linux-firmware > without kernel-modules > is pointless. > > IMO, the config choice is whether to install > MACHINE_EXTRA_RRECOMMENDS > or not. > Agreed, I was not actually testing the actual patch (my bad), and the difference between EXTRA and ESSENTIAL is exactly as mentioned above, I withdraw my objection to this patch.
Sau! > -- Mikko -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
