Hi, Thank you for the patch. I have a few comments:
On Sun, 2018-12-23 at 15:03 +0530, Ankit Navik wrote: > Add generic recipe for Metrics Discovery API. > Its a user mode library that provides access to GPU performance data. > > Signed-off-by: Ankit Navik <[email protected]> > --- > recipes-graphics/mdapi/mdapi_git.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 recipes-graphics/mdapi/mdapi_git.bb Can you rename the recipe to metrics-discovery please since that is the name of the project? > > diff --git a/recipes-graphics/mdapi/mdapi_git.bb b/recipes- > graphics/mdapi/mdapi_git.bb > new file mode 100644 > index 0000000..2e60f53 > --- /dev/null > +++ b/recipes-graphics/mdapi/mdapi_git.bb > @@ -0,0 +1,17 @@ > +SUMMARY = "Intel Metrics Discovery Application Programming > Interface" > +DESCRIPTION = "This software is a user mode library that provides > access to \ > +GPU performance data." > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = > "file://LICENSE.md;md5=5ac9e51fb25f5d5b10a1bea412a4b74c" > +SECTION = "lib" > + > +inherit pkgconfig cmake > + > +S = "${WORKDIR}/git" > +SRCREV = "a6accaf9844d453177047866caaa9eda34582de9" > +SRC_URI = "git://github.com/intel/metrics-discovery.git" This needs PV to be defined as well. > + > +EXTRA_OECMAKE += "-DMD_PLATFORM=linux -DMD_PLATFORM=linux" And please remove the duplicate option ... > +EXTRA_OECMAKE += "-DMD_LIBDRM_SRC=${STAGING_INCDIR}" > + > +DEPENDS = "libdrm" > -- > 2.7.4 > -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
