On Tue, 2019-02-12 at 18:44 +0530, Ankit Navik wrote: > > > +LICENSE = "Apache-2.0" > > > +LIC_FILES_CHKSUM = > > > "file://LICENSE;md5=afa44a3d001cc203032135324f9636b7"
This is missing some licenses for tests. Can you please add the ones at the bottom of this list: https://github.com/intel/mkl-dnn/blob/master/LICENSE > > > +SECTION = "lib" > > > + > > > +inherit pkgconfig cmake > > > + > > > +S = "${WORKDIR}/git" > > > +SRCREV = "08bd90cca77683dd5d1c98068cea8b92ed05784d" Can we use 0.17.4 version instead of 0.18 since that has not been released yet and is still an rc? > > > +SRC_URI = "git://github.com/intel/mkl-dnn.git" > > > + > > > +EXTRA_OECMAKE += "-DMKLDNN_LIBRARY_TYPE=SHARED" > > > +EXTRA_OECMAKE += "-DMKLDNN_THREADING=OMP" > > > > I meant continue enabling the tests/examples, but create a > > subpackage called ${PN}-examples for the example files. > > > > I am checking it. Facing some issue "bad RPATH" for tests and > examples. > Meanwhile, Is it possible to accept the patch v1. > I'll fix and submit another patch to include the tests and examples. It looks like the tests/examples are not installed even when enabled ... So this might also need tweaks in Makefile/do_install for those to be installed and packaged. -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
