On 03/22/2019 10:13 PM, Burton, Ross wrote:
> On Fri, 22 Mar 2019 at 02:24, Liwei Song <[email protected]> wrote:
>> +PARALLEL_MAKE = ""
>
> Is this really needed? How about at least filing a bug upstream.
If do not add this, we will got build error in a low rate about 1/10, due to an
parallel build for it, so we may need keep this until it is fixed.
I will try to file a bug to ledmon upstream.
>
>> +SRC_URI = "git://github.com/intel/ledmon;branch=master"
>> +SRCREV = "8a5d9526e5666e75625427b85a2586436651e89c"
>
> Upstream tags releases, so please set the filename to (for example)
> ledmon_0.90.git and then set SRCREV to the sha of that tag.
Got it, will modify according this format.
>
>> +EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
>
> Are these needed, as they're exported. If we need to pass LDFLAGS
> like this, why not CFLAGS?
This is used to fix an QA WARNING:
WARNING: ledmon-0.90-git do_package_qa: QA Issue: No GNU_HASH in the ELF binary
/project/tmp-glibc/work/corei7-64-wrs-linux/ledmon/0.90-git/packages-split/ledmon/usr/sbin/ledmon,
didn't pass LDFLAGS?
>
>> +do_compile() {
>> + oe_runmake SYSROOT="${STAGING_DIR_TARGET}"
>> +}
>
> ross@blackadder ~/Downloads/Holding/ledmon (master)
> $ git grep SYSROOT|wc -l
> 0
>
> Why are you passing SYSROOT?
Will delete it.
>
>> +do_install() {
>> + oe_runmake install DESTDIR=${D}
>> + cd ${S}/systemd
>> + oe_runmake install DESTDIR=${D}
>> +}
>
> There's an install-systemd target so you could just do:
>
> oe_runmake DESTDIR=${D} install install-systemd
Thanks, will use install-systemd target
Liwei.
>
> Ross
>
>
--
_______________________________________________
meta-intel mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-intel
