Hi Kevin, I have a few comments:
On Fri, 2019-05-24 at 09:36 +0800, Kevin Hao wrote: ... > +From d50d2a8f3da588c0aaeb95116a88be5a598b4b16 Mon Sep 17 00:00:00 > 2001 > +From: Kevin Hao <[email protected]> > +Date: Thu, 23 May 2019 15:34:20 +0800 > +Subject: [PATCH] Drop the unneeded files when installation > + > +These are not needed as part of image. Drop them to avoid the QA > +warning. > + Since it's only just one app, could we package it in FILES_PN-examples? If not, we should probably just remove it in do_install_append and not carry this patch. We also probably don't need to delete the installation of mk folder since they are being packaged now: https://git.yoctoproject.org/cgit/cgit.cgi/meta-dpdk/commit/?id=4582cde191b3b06b9b8f34bcd3fdd6c8a2d5e838 Can you please check? ... > diff --git a/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for- > parellel-make-issue.patch b/recipes-extended/dpdk/dpdk/dpdk-18.11- > dpdk-fix-for-parellel-make-issue.patch > new file mode 100644 > index 000000000000..e95c9a4ff5ce > --- /dev/null > +++ b/recipes-extended/dpdk/dpdk/dpdk-18.11-dpdk-fix-for-parellel- > make-issue.patch > @@ -0,0 +1,42 @@ > +From 5e78af18b6dda83e317ccadab1654fca26aaf6dd Mon Sep 17 00:00:00 > 2001 > +From: Rahul Kumar Gupta <[email protected]> > +Date: Fri, 2 Sep 2016 15:48:52 +0800 > +Subject: [PATCH] dpdk: fix for parellel make issue > + > +To make sure that the path of libraries should be correct and > +libraries will be build before, And available at the time of > +linking example apps. Can you add Upstream-Status here please and try submitting it upstream? ... > diff --git a/recipes-extended/dpdk/dpdk_18.11.1.bb b/recipes- > extended/dpdk/dpdk_18.11.1.bb > new file mode 100644 > index 000000000000..2cb84924a757 > --- /dev/null > +++ b/recipes-extended/dpdk/dpdk_18.11.1.bb > @@ -0,0 +1,15 @@ > +include dpdk.inc > + > +STABLE = "-stable" > +BRANCH = "18.11" > +SRCREV = "16ece46735c9b70b7033ca7ae095930e9038d9fd" > + > +LICENSE = "BSD & LGPLv2 & GPLv2" Should these be BSD-3-Clause & LGPLv2.1 & GPLv2 based on the files included below? > +LIC_FILES_CHKSUM = "file://license/gpl- > 2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ > + file://license/lgpl- > 2.1.txt;md5=4b54a1fd55a448865a0b32d41598759d \ > + file://license/bsd-3- > clause.txt;md5=0f00d99239d922ffd13cabef83b33444" > + > +SRC_URI += "\ > + file://dpdk-18.11-dpdk-fix-for-parellel-make-issue.patch > \ > + file://dpdk-18.11-Drop-the-unneeded-files-when- > installation.patch \ > +" -- _______________________________________________ meta-intel mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-intel
