On 1/3/20 6:35 PM, Theodore A. Roth wrote:
> On Fri, Jan 3, 2020 at 2:30 PM Andrew F. Davis <[email protected]> wrote:
>>
>> On 1/2/20 2:40 PM, Theodore A. Roth wrote:
>>> Signed-off-by: Theodore A. Roth <[email protected]>
>>> ---
>>>  conf/machine/beagle-x15.conf | 5 ++++-
>>
>>
>> Why add this to the X15 machine? The Beagebone AI is not an X15, the
>> catch all for AM57xx machines seems to be am57xx-evm.conf, which already
>> has the am5729-beagleboneai.dtb.
> 
> I tried building an image using the am57xx-evm.conf machine in the first 
> place,
> but it didn't build the wic image, so I added it to the X15 (since they have 
> the
> same processor). The X15 machine seemed a good place to put it due to the
> similarities. Seemed similar to what is going on in the beaglebone.conf 
> machine
> file (lots of very different boards handled in a single machine file).
> 
>>
>> Thinking more about this, the defining features of the AI might warrant
>> a new machine conf.
> 
> I'm not opposed to adding a new beagle-ai.conf machine. Looking at
> the X15 machine conf, it seems that there would not be much different
> for the BBAI other than possibly MACHINE_GUI_CLASS and SERIAL_CONSOLES.
> 


Seems the only difference is in the display (the serial console looks
the same for both).

The AM57xx-EVM is basically just an x15 but with a touchscreen attached:

MACHINE_FEATURES += "touchscreen"

The X15 on the other-hand uses HDMI:

MACHINE_GUI_CLASS = "bigscreen"

If we can remove these differences (auto detect them in userspace or
something), then we can combine am57xx-evm.conf and beagle-x15.conf into
just one machine target, which to me is the best way to it (reduce
targets means less testing, etc..)


> Any ideas or hints on what would be different in the machine conf for BBAI
> versus the X15?


Looks like for your wic image IMAGE_FSTYPES could be changed from
"tar.xz" to "tar.xz wic.xz" so both are generated using the
am57xx-evm.conf target. What do you use the wic image for anyway, I'm
not familiar with it?


> 
> I'm also not sure why beagle-x15.conf has UBIFS stuff it it since that board 
> has
> an eMMC nand flash device on it.
> 


Possibly left over from when it was forked from am57xx-evm.conf. So as
above, re-combining to one superset machine will help prevent this kind
of thing.

Andrew


> Thanks for the feedback.
> 
> Ted Roth
> 
>>
>> Andrew
>>
>>
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/conf/machine/beagle-x15.conf b/conf/machine/beagle-x15.conf
>>> index d5e05ec7..0af45a84 100644
>>> --- a/conf/machine/beagle-x15.conf
>>> +++ b/conf/machine/beagle-x15.conf
>>> @@ -4,7 +4,10 @@
>>>
>>>  require conf/machine/include/dra7xx.inc
>>>
>>> -KERNEL_DEVICETREE = "am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb 
>>> am57xx-beagle-x15-revc.dtb"
>>> +KERNEL_DEVICETREE = " \
>>> +    am57xx-beagle-x15.dtb am57xx-beagle-x15-revb1.dtb 
>>> am57xx-beagle-x15-revc.dtb \
>>> +    am5729-beagleboneai.dtb \
>>> +"
>>>
>>>  MACHINE_GUI_CLASS = "bigscreen"
>>>
>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#12591): 
>>> https://lists.yoctoproject.org/g/meta-ti/message/12591
>>> Mute This Topic: https://lists.yoctoproject.org/mt/69386296/3619733
>>> Group Owner: [email protected]
>>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub  [[email protected]]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12599): 
https://lists.yoctoproject.org/g/meta-ti/message/12599
Mute This Topic: https://lists.yoctoproject.org/mt/69386296/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub  
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to