Most of the below is just a standard git workflow and Open Source process...
Here are the basic guidelines for the OpenEmbedded commit messages: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines For commit message itself, "recipes-bsp: cpsw9g-eth-fw: Update SRCREV to latest" would be fine, or even simly "cpsw9g-eth-fw: Update SRCREV to latest" When you create a patch with git format-patch, it automatically prepends commit message with [PATCH] for a single patch or [PATCH x/y] for a series. You can also specify if it's not the first revision, resulting in [PATCH v2]. BTW, the default for the first revision is not to have "v1". You can also specify which branch you need this merged to in a separate brackets like [dunfell/master] or [thud], etc. The default is the current LTS and master, thus [dunfell/master] is assumed, if omitted, but still nice to have. There's no need to add mailing list prefix, as it will be added automatically by the mail server. Nesting brackets are not allowed - Patchwork chokes on them and mangles the commit log (e.g. this original patch). And no need to cram everything into a single set of brackets. So, all in all, here's a proper Subject line for a patch sent to the list: Subject: [meta-ti][dunfell/master][PATCH v3 4/7] recipe: brief change summary Please note that [meta-ti] will be added automatically by the mailing list. Also it indicates that it is a 3-rd revision of the patch, which is #4 in a series of 7 patches total. Need to be applied to dunfell and master branches. All information inside square brackets is only for the maintainer and will be automatically discarded when merged into git repo. Also, some Open Source communities and mailing lists require copying maintainers directly, besides the list, which is not required for meta-ti and meta-arago. I usually prefer when a patch is send just to the list. Further discussions and replies can then be copied between participant. Hope this helps, especially since we are getting influx of new patch submitters lately. Please let me know of any further questions. Oh, and please don't forget that this list is public and is community oriented. Anything you post or say will be seen by hundreds of community people. -- Denys On Tue, Jul 07, 2020 at 01:20:59PM -0400, Jondhale, Prasad wrote: > Actually this is what I have in my confluence instructions. Should this be > removed? What should it be replaced with? > Is just " recipes-bsp: cpsw9g-eth-fw: Update SRCREV to latest" fine? > > Regards, > Prasad > > > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Tuesday, July 7, 2020 10:49 PM > To: Jondhale, Prasad > Cc: [email protected]; [email protected]; > [email protected] - Auto Ethernet firmware development team > Subject: Re: [[meta-ti][Dunfell/master PATCH v1] recipes-bsp: cpsw9g-eth-fw: > Update SRCREV to latest > > [[meta-ti][Dunfell/master PATCH v1] recipes-bsp: cpsw9g-eth-fw: Update SRCREV > to latest > > This is better, but what's with "[[meta-ti][Dunfell/master PATCH v1]"? > > > On Tue, Jul 07, 2020 at 10:47:21PM +0530, Prasad Jondhale wrote: > > Signed-off-by: Prasad Jondhale <[email protected]> > > --- > > recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb > > b/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb > > index 37ba52d0..8cb62b2a 100755 > > --- a/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb > > +++ b/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb > > @@ -11,7 +11,7 @@ inherit update-alternatives > > > > PROTOCOL = "git" > > BRANCH = "master" > > -SRCREV = "afe62ada2e91e2665f597ca16eb3888b752016de" > > +SRCREV = "91f1628507bf7f8716f0bc7cafe88ad7f14c94f5" > > > > SRC_URI = > > "git://git.ti.com/glsdk/ti-eth-fw.git;protocol=${PROTOCOL};branch=${BRANCH}" > > > > -- > > 2.17.1 > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13029): https://lists.yoctoproject.org/g/meta-ti/message/13029 Mute This Topic: https://lists.yoctoproject.org/mt/75359713/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
