On 21:51-20210524, Denys Dmytriyenko wrote:
> On Mon, May 24, 2021 at 05:40:36PM -0500, Yogesh Siraswar via 
> lists.yoctoproject.org wrote:
> > Added KERNEL_DTB_OVERLAY_SUPPORT to individual MACHINE conf to
> > compile dtbs with symbols. This fixes the issue where the dtbs
> > are build without symbols causing issue with overlays.
> > 
> > Enabling overlay support increases the size of the dtb, hence
> > it is done at a platform level rather than globally to allow custom
> > boards disable it from local.conf to reduce size.
> > 

^^

> > Signed-off-by: Yogesh Siraswar <[email protected]>
> > ---
> >  conf/machine/am335x-evm.conf                  | 2 ++
> >  conf/machine/am335x-hs-evm.conf               | 2 ++
> >  conf/machine/am437x-evm.conf                  | 2 ++
> >  conf/machine/am437x-hs-evm.conf               | 2 ++
> >  conf/machine/am57xx-evm.conf                  | 2 ++
> >  conf/machine/am57xx-hs-evm.conf               | 3 +++
> >  conf/machine/am65xx-evm.conf                  | 2 ++
> >  conf/machine/am65xx-hs-evm.conf               | 2 ++
> >  conf/machine/dra7xx-evm.conf                  | 2 ++
> >  conf/machine/dra7xx-hs-evm.conf               | 3 +++
> >  conf/machine/j7-evm.conf                      | 2 ++
> >  conf/machine/j7-hs-evm.conf                   | 2 ++
> >  conf/machine/j7200-evm.conf                   | 2 ++
> >  conf/machine/k2g-evm.conf                     | 2 ++
> >  conf/machine/k2g-hs-evm.conf                  | 2 ++
> 
> First question:
> If you are weakly assigning KERNEL_DTB_OVERLAY_SUPPORT in most of the machine 
> configs, should it instead be done in SoC include files, like ti33x.inc, 
> k3.inc or even ti-soc.inc?

You would want the default behavior as default dtb, not the bloated
symbol loaded overlay capable dtb, no?

[...]

> > +
> > +def get_extra_dtc_args(d):
> > +    if d.getVar('KERNEL_DTB_OVERLAY_SUPPORT') == "1":
> > +        return "DTC_FLAGS=-@"
> > +    else:
> > +        return ""
> > +
> > +EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}"
> 
> Second question:
> Are there any specific future plans for EXTRA_DTC_ARGS? As it seems to be 
> an unused intermediary variable right now - you can directly append to 
> KERNEL_EXTRA_ARGS here...

dtc changes are always incoming, does'nt make sense to keep that
separated out?


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 
1736 249D
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13795): 
https://lists.yoctoproject.org/g/meta-ti/message/13795
Mute This Topic: https://lists.yoctoproject.org/mt/83064187/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to