On 09:02-20221017, Andrew Davis wrote:
> On 10/12/22 5:09 AM, Manorit Chawdhry wrote:
> > Sign the firmwares for j784s4 similar to j721s2 hs.
> > Duplicate all j784s4 entries for j784s4-hs as we cannot use same
> > keyword for match between j784s4-evm and j784s4-hs-evm.
> > 
> > Signed-off-by: Manorit Chawdhry <[email protected]>
> > ---
> >   recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 135 +++++++++++++++++++++
> >   1 file changed, 135 insertions(+)
> > 
> > diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb 
> > b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > index 68c93ae7..f3b7d416 100644
> > --- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > +++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > @@ -20,6 +20,7 @@ PLAT_SFX_j7200-hs-evm = "j7200"
> >   PLAT_SFX_j721s2-evm = "j721s2"
> >   PLAT_SFX_j721s2-hs-evm = "j721s2"
> >   PLAT_SFX_j784s4-evm = "j784s4"
> > +PLAT_SFX_j784s4-hs-evm = "j784s4"
> >   PLAT_SFX_am65xx = "am65xx"
> >   PLAT_SFX_am64xx = "am64xx"
> >   PLAT_SFX_am62xx = "am62xx"
> > @@ -128,6 +129,38 @@ do_install_prepend_j721s2-hs-evm() {
> >           )
> >   }
> > +# J784S4 support
> > +do_install_prepend_j784s4-hs-evm() {
> > +        export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
> > +        ( cd ${RTOS_DM_FW_DIR}; \
> > +                mv ${DM_FIRMWARE} ${DM_FIRMWARE}.unsigned; \
> > +                ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ${DM_FIRMWARE}.unsigned ${DM_FIRMWARE}; \
> > +        )
> > +        (
> > +          cd ${RTOS_IPC_FW_DIR}; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_mcu2_0_release_strip.xer5f \
> > +                ipc_echo_test_mcu2_0_release_strip.xer5f.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_mcu2_1_release_strip.xer5f \
> > +                ipc_echo_test_mcu2_1_release_strip.xer5f.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_mcu3_0_release_strip.xer5f \
> > +                ipc_echo_test_mcu3_0_release_strip.xer5f.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_mcu3_1_release_strip.xer5f \
> > +                ipc_echo_test_mcu3_1_release_strip.xer5f.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_mcu4_0_release_strip.xer5f \
> > +                ipc_echo_test_mcu4_0_release_strip.xer5f.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_mcu4_1_release_strip.xer5f \
> > +                ipc_echo_test_mcu4_1_release_strip.xer5f.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_c7x_1_release_strip.xe71 \
> > +                ipc_echo_test_c7x_1_release_strip.xe71.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_c7x_2_release_strip.xe71 \
> > +                ipc_echo_test_c7x_2_release_strip.xe71.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_c7x_3_release_strip.xe71 \
> > +                ipc_echo_test_c7x_3_release_strip.xe71.signed; \
> > +            ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh 
> > ipc_echo_test_c7x_4_release_strip.xe71 \
> > +                ipc_echo_test_c7x_4_release_strip.xe71.signed; \
> > +        )
> > +}
> > +
> >   # Update the am64xx ipc binaries to be consistent with other platforms
> >   do_install_prepend_am64xx() {
> >           ( cd ${RTOS_IPC_FW_DIR}; \
> > @@ -248,6 +281,37 @@ do_install_j721s2-hs-evm() {
> >       # install -m 0644 
> > ${RTOS_ETH_FW_DIR}/app_remoteswitchcfg_server_strip.xer5f 
> > ${LEGACY_ETH_FW_DIR}
> >   }
> > +do_install_j784s4-hs-evm() {
> > +    install -d ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu1_1_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu2_0_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu2_1_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu3_0_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu3_1_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu4_0_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu4_1_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_1_release_strip.xe71 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_2_release_strip.xe71 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_3_release_strip.xe71 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_4_release_strip.xe71 
> > ${LEGACY_IPC_FW_DIR}
> > +    # Signed firmware
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu2_0_release_strip.xer5f.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu2_1_release_strip.xer5f.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu3_0_release_strip.xer5f.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu3_1_release_strip.xer5f.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu4_0_release_strip.xer5f.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu4_1_release_strip.xer5f.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_1_release_strip.xe71.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_2_release_strip.xe71.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_3_release_strip.xe71.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_c7x_4_release_strip.xe71.signed 
> > ${LEGACY_IPC_FW_DIR}
> > +    # DM Firmware
> > +    install -m 0644 
> > ${RTOS_DM_FW_DIR}/ipc_echo_testb_mcu1_0_release_strip.xer5f 
> > ${LEGACY_DM_FW_DIR}
> > +    # ETH firmware
> > +    install -d ${LEGACY_ETH_FW_DIR}
> > +    install -m 0644 
> > ${RTOS_ETH_FW_DIR}/app_remoteswitchcfg_server_strip.xer5f 
> > ${LEGACY_ETH_FW_DIR}
> > +}
> > +
> >   do_install_j784s4-evm() {
> >       install -d ${LEGACY_IPC_FW_DIR}
> >       install -m 0644 
> > ${RTOS_IPC_FW_DIR}/ipc_echo_test_mcu1_1_release_strip.xer5f 
> > ${LEGACY_IPC_FW_DIR}
> > @@ -408,6 +472,31 @@ ALTERNATIVE_${PN}_j784s4-evm = "\
> >                       j784s4-c71_3-fw \
> >                       "
> > +ALTERNATIVE_${PN}_j784s4-hs-evm = "\
> > +                    j784s4-mcu-r5f0_0-fw \
> > +                    j784s4-mcu-r5f0_1-fw \
> > +                    j784s4-main-r5f0_0-fw \
> > +                    j784s4-main-r5f0_1-fw \
> > +                    j784s4-main-r5f1_0-fw \
> > +                    j784s4-main-r5f1_1-fw \
> > +                    j784s4-main-r5f2_0-fw \
> > +                    j784s4-main-r5f2_1-fw \
> > +                    j784s4-c71_0-fw \
> > +                    j784s4-c71_1-fw \
> > +                    j784s4-c71_2-fw \
> > +                    j784s4-c71_3-fw \
> > +               j784s4-main-r5f0_0-fw-sec \
> 
> 
> Looks like a couple tabs snuck in on this line..
> 
> Other than that, this patch looks fine to me. Maybe one minor
> thing you could do though, split this into two, one for adding the
> normal firmware, second for adding the extra signed firmware.
> 
> Andrew
> 

Okay, will update it.

Thanks,
Manorit

> 
> > +                    j784s4-main-r5f0_1-fw-sec \
> > +                    j784s4-main-r5f1_0-fw-sec \
> > +                    j784s4-main-r5f1_1-fw-sec \
> > +                    j784s4-main-r5f2_0-fw-sec \
> > +                    j784s4-main-r5f2_1-fw-sec \
> > +                    j784s4-c71_0-fw-sec \
> > +                    j784s4-c71_1-fw-sec \
> > +                    j784s4-c71_2-fw-sec \
> > +                    j784s4-c71_3-fw-sec \
> > +                    "
> > +
> >   # Set up link names for the firmwares
> >   TARGET_MCU_R5FSS0_0_am65xx = "am65x-mcu-r5f0_0-fw"
> > @@ -491,6 +580,30 @@ TARGET_C7X_1_j784s4-evm = "j784s4-c71_1-fw"
> >   TARGET_C7X_2_j784s4-evm = "j784s4-c71_2-fw"
> >   TARGET_C7X_3_j784s4-evm = "j784s4-c71_3-fw"
> > +TARGET_MCU_R5FSS0_0_j784s4-hs-evm = "j784s4-mcu-r5f0_0-fw"
> > +TARGET_MCU_R5FSS0_1_j784s4-hs-evm = "j784s4-mcu-r5f0_1-fw"
> > +TARGET_MAIN_R5FSS0_0_j784s4-hs-evm = "j784s4-main-r5f0_0-fw"
> > +TARGET_MAIN_R5FSS0_1_j784s4-hs-evm = "j784s4-main-r5f0_1-fw"
> > +TARGET_MAIN_R5FSS1_0_j784s4-hs-evm = "j784s4-main-r5f1_0-fw"
> > +TARGET_MAIN_R5FSS1_1_j784s4-hs-evm = "j784s4-main-r5f1_1-fw"
> > +TARGET_MAIN_R5FSS2_0_j784s4-hs-evm = "j784s4-main-r5f2_0-fw"
> > +TARGET_MAIN_R5FSS2_1_j784s4-hs-evm = "j784s4-main-r5f2_1-fw"
> > +TARGET_C7X_0_j784s4-hs-evm = "j784s4-c71_0-fw"
> > +TARGET_C7X_1_j784s4-hs-evm = "j784s4-c71_1-fw"
> > +TARGET_C7X_2_j784s4-hs-evm = "j784s4-c71_2-fw"
> > +TARGET_C7X_3_j784s4-hs-evm = "j784s4-c71_3-fw"
> > +
> > +TARGET_MAIN_R5FSS0_0_SIGNED_j784s4-hs-evm = "j784s4-main-r5f0_0-fw-sec"
> > +TARGET_MAIN_R5FSS0_1_SIGNED_j784s4-hs-evm = "j784s4-main-r5f0_1-fw-sec"
> > +TARGET_MAIN_R5FSS1_0_SIGNED_j784s4-hs-evm = "j784s4-main-r5f1_0-fw-sec"
> > +TARGET_MAIN_R5FSS1_1_SIGNED_j784s4-hs-evm = "j784s4-main-r5f1_1-fw-sec"
> > +TARGET_MAIN_R5FSS2_0_SIGNED_j784s4-hs-evm = "j784s4-main-r5f2_0-fw-sec"
> > +TARGET_MAIN_R5FSS2_1_SIGNED_j784s4-hs-evm = "j784s4-main-r5f2_1-fw-sec"
> > +TARGET_C7X_0_SIGNED_j784s4-hs-evm = "j784s4-c71_0-fw-sec"
> > +TARGET_C7X_1_SIGNED_j784s4-hs-evm = "j784s4-c71_1-fw-sec"
> > +TARGET_C7X_2_SIGNED_j784s4-hs-evm = "j784s4-c71_2-fw-sec"
> > +TARGET_C7X_3_SIGNED_j784s4-hs-evm = "j784s4-c71_3-fw-sec"
> > +
> >   ALTERNATIVE_LINK_NAME[am65x-mcu-r5f0_0-fw] = 
> > "${base_libdir}/firmware/${TARGET_MCU_R5FSS0_0}"
> >   ALTERNATIVE_LINK_NAME[am65x-mcu-r5f0_1-fw] = 
> > "${base_libdir}/firmware/${TARGET_MCU_R5FSS0_1}"
> > @@ -558,6 +671,17 @@ ALTERNATIVE_LINK_NAME[j784s4-c71_1-fw] = 
> > "${base_libdir}/firmware/${TARGET_C7X_1
> >   ALTERNATIVE_LINK_NAME[j784s4-c71_2-fw] = 
> > "${base_libdir}/firmware/${TARGET_C7X_2}"
> >   ALTERNATIVE_LINK_NAME[j784s4-c71_3-fw] = 
> > "${base_libdir}/firmware/${TARGET_C7X_3}"
> > +ALTERNATIVE_LINK_NAME[j784s4-main-r5f0_0-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_MAIN_R5FSS0_0_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-main-r5f0_1-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_MAIN_R5FSS0_1_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-main-r5f1_0-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_MAIN_R5FSS1_0_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-main-r5f1_1-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_MAIN_R5FSS1_1_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-main-r5f2_0-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_MAIN_R5FSS2_0_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-main-r5f2_1-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_MAIN_R5FSS2_1_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-c71_0-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_C7X_0_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-c71_1-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_C7X_1_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-c71_2-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_C7X_2_SIGNED}"
> > +ALTERNATIVE_LINK_NAME[j784s4-c71_3-fw-sec] = 
> > "${base_libdir}/firmware/${TARGET_C7X_3_SIGNED}"
> > +
> >   # Create the firmware alternatives
> >   ALTERNATIVE_TARGET[am65x-mcu-r5f0_0-fw] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu1_0_release_strip.xer5f"
> > @@ -627,6 +751,17 @@ ALTERNATIVE_TARGET[j784s4-c71_1-fw] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_
> >   ALTERNATIVE_TARGET[j784s4-c71_2-fw] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_c7x_3_release_strip.xe71"
> >   ALTERNATIVE_TARGET[j784s4-c71_3-fw] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_c7x_4_release_strip.xe71"
> > +ALTERNATIVE_TARGET[j784s4-main-r5f0_0-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu2_0_release_strip.xer5f.signed"
> > +ALTERNATIVE_TARGET[j784s4-main-r5f0_1-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu2_1_release_strip.xer5f.signed"
> > +ALTERNATIVE_TARGET[j784s4-main-r5f1_0-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu3_0_release_strip.xer5f.signed"
> > +ALTERNATIVE_TARGET[j784s4-main-r5f1_1-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu3_1_release_strip.xer5f.signed"
> > +ALTERNATIVE_TARGET[j784s4-main-r5f2_0-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu4_0_release_strip.xer5f.signed"
> > +ALTERNATIVE_TARGET[j784s4-main-r5f2_1-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_mcu4_1_release_strip.xer5f.signed"
> > +ALTERNATIVE_TARGET[j784s4-c71_0-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_c7x_1_release_strip.xe71.signed"
> > +ALTERNATIVE_TARGET[j784s4-c71_1-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_c7x_2_release_strip.xe71.signed"
> > +ALTERNATIVE_TARGET[j784s4-c71_2-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_c7x_3_release_strip.xe71.signed"
> > +ALTERNATIVE_TARGET[j784s4-c71_3-fw-sec] = 
> > "${base_libdir}/firmware/pdk-ipc/ipc_echo_test_c7x_4_release_strip.xe71.signed"
> > +
> >   ALTERNATIVE_PRIORITY = "10"
> >   # make sure that lib/firmware, and all its contents are part of the 
> > package
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15180): 
https://lists.yoctoproject.org/g/meta-ti/message/15180
Mute This Topic: https://lists.yoctoproject.org/mt/94277613/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to