On 2/9/23 2:20 AM, Sinthu Raja M via lists.yoctoproject.org wrote:
From: Sinthu Raja <[email protected]>

K3 platforms include the fit image-based kernel as the default. The fit

Not "as the default", rather "by default". Only HS has it as "the" default.

image loads the kernel and DTB. The DTB/DTBOs, however, are added to the

The FIT image does not do the loading, U-Boot/SBL does. Recommend change
the wording to "The bootloader loads the kernel and DTB from the FIT image".

Remove ", however,".

fit image, but the load address is not included in the image section of
each DTB/DTBO, for non-HS platforms. This load address is determined by
the LOADADDRESS macros in the kernel-fitmage class.

Hence, in K3, include the DTB/DTBOs load address and offset macros, which
will be used by all K3 platforms.

Include them where? The whole point of the patch is you are now including
them in a common include file, that should be stated.

"FIT" is an acronym, capitalize it everywhere.


Signed-off-by: Sinthu Raja <[email protected]>
---

Hi,
Build tested locally and validated the fitImage on AM68 SK.

Changes in V2:
=============
Address review comment:
- Move the change to k3.inc as the fit image is included as default
   image across all platforms

V1: https://lists.yoctoproject.org/g/meta-ti/message/15754
conf/machine/include/k3.inc | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/conf/machine/include/k3.inc b/conf/machine/include/k3.inc
index 81139571..96f7dbd5 100644
--- a/conf/machine/include/k3.inc
+++ b/conf/machine/include/k3.inc
@@ -21,6 +21,9 @@ KERNEL_CLASSES += "kernel-fitimage"
  UBOOT_ARCH = "arm"
  UBOOT_ENTRYPOINT = "0x80008000"
  UBOOT_LOADADDRESS = "0x80008000"
+UBOOT_DTB_LOADADDRESS =  "0x83000000"
+UBOOT_DTBO_LOADADDRESS = "0x83080000"
+UBOOT_DTBO_OFFSET =      "0x00010000"

Should include UBOOT_RD_* also.

Now that you add this info here, all other files that include this
file should have these lines removed.

Andrew

SPL_BINARY = "tispl.bin"
  SPL_BINARYNAME = "tispl.bin"





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#15772): 
https://lists.yoctoproject.org/g/meta-ti/message/15772
Mute This Topic: https://lists.yoctoproject.org/mt/96849292/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to