On Wed, Apr 05, 2023 at 08:08:42PM -0400, Denys Dmytriyenko wrote: > On Mon, Apr 03, 2023 at 03:48:05PM +0200, Alexandre Belloni via > lists.yoctoproject.org wrote: > > Hello, > > > > meta-ti is currently failing check-layer-nightly: > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1272/steps/19/logs/stdio > > > > AssertionError: Adding layer meta-ti-bsp changed signatures. > > 10 signatures changed, initial differences (first hash before, second > > after): > > optee-client:do_prepare_recipe_sysroot: > > 3f4e44718ab8f2398d5cc145fcdd481d1813a7afb7d028aa5ff67617fec69885 -> > > 06b063bf17bd8534f2ffc2506780d02c221cca3273863d3ca2548f2031c3ff92 > > bitbake-diffsigs --task optee-client do_prepare_recipe_sysroot > > --signature > > 3f4e44718ab8f2398d5cc145fcdd481d1813a7afb7d028aa5ff67617fec69885 > > 06b063bf17bd8534f2ffc2506780d02c221cca3273863d3ca2548f2031c3ff92 > > NOTE: Starting bitbake server... > > runtaskdeps changed: > > ['cmake/cmake-native_3.22.3.bb:do_populate_sysroot > > gcc/gcc-cross_11.3.bb:do_populate_sysroot > > gcc/gcc-runtime_11.3.bb:do_populate_sysroot > > glibc/glibc_2.35.bb:do_populate_sysroot > > ninja/ninja_1.10.2.bb:do_populate_sysroot:virtual:native > > optee/optee-client_3.16.0.bb:do_fetch', > > +pkgconfig/pkgconfig_git.bb:do_populate_sysroot:virtual:native, > > 'pseudo/pseudo_git.bb:do_populate_sysroot:virtual:native > > update-rc.d/update-rc.d_0.8.bb:do_populate_sysroot'] > > Number of task dependencies changed > > Dependency on task > > pkgconfig/pkgconfig_git.bb:do_populate_sysroot:virtual:native was added > > with hash cf8a9ff6ed2d492aeeeeeb3972365104425b5424377cf5e4a4fc76bb53a4f628 > > Alexandre, > > Trying to push latest OPTEE updates to meta-arm now, so we can remove local > bbappends in meta-ti: > > https://lists.yoctoproject.org/g/meta-arm/message/4556 > > > > > There as also this one over the week end: > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1268/steps/20/logs/stdio > > > > > > AssertionError: 3 != 0 : Found following patches with malformed or missing > > upstream status: > > /home/pokybuild/yocto-worker/check-layer-nightly/build/meta-ti/meta-ti-extras/recipes-bsp/wl18xx-fw/wl18xx-fw/0001-Add-Makefile-to-install-firmware-files.patch > > /home/pokybuild/yocto-worker/check-layer-nightly/build/meta-ti/meta-ti-extras/recipes-devtools/gdbc6x/gdbc6x/0001-libbfd.h-suppress-GCC9-Wstringop-truncation.patch > > /home/pokybuild/yocto-worker/check-layer-nightly/build/meta-ti/meta-ti-extras/recipes-connectivity/wl18xx-target-scripts/wl18xx-target-scripts/0001-print_stat.sh-replace-system-bin-sh-with-bin-sh.patch > > Ryan, > > BTW, Upstream-Status: tag in local patches is now being checked as well, so > we > should go over the above list and at least add "Pending" or "Inappropriate" > status now. Can you take care of these?
Ryan, I'm sure you know this... But for everyone else on meta-ti list, here's a Wiki page detailing the Upstream-Status: tag use in OpenEmbedded (and by extension, the Yocto Project): https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status The biggest issue people have when first confronted with this, is where to put it. And since they create a patch to submit to the mailing list, they add it to the commit log. This should rather go in the actual local *.patch file when one gets added to the layer. When preparing email to be sent to the meta-ti list, it should be in the inner patch, not the outer - when merged, it should not be in the commit log, but rather inside the actual *.patch file. And since this is now a requirement to maintain Yocto Project compliance, you would have to enforce it going forward. Thanks. -- Denys
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16302): https://lists.yoctoproject.org/g/meta-ti/message/16302 Mute This Topic: https://lists.yoctoproject.org/mt/98035454/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/6695321/21656/1393940836/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
