Hi Denys,

Thanks for the review,

On 14/06/23 20:24, Denys Dmytriyenko wrote:
> On Wed, Jun 14, 2023 at 08:03:05PM +0530, Devarsh Thakkar via 
> lists.yoctoproject.org wrote:
>> Early splash screen support for AM62x has been enabled in u-boot
>> and it requires bitmap tarball to be present in boot partition
>> as per the default environment settings done in u-boot [1].
>>
>> Copy the ti logo bitmap tarball to boot partition of wic image in order
>> to enable out of box early display on AM62x.
>>
>> [1] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env
>>
>> Signed-off-by: Devarsh Thakkar <[email protected]>
>> ---
>> V2: Rename ti logo tarball as per suggested changes (same is being
>>     done in ti-u-boot too)
>> ---
>>  .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb      | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb 
>> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb
>> index e6da84cb..c948e1ed 100644
>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb
>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb
>> @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04"
>>  
>>  SRCREV = "1f510931dcc90e6f28f7fed757ad5000d4382e22"
>>  
>> +do_install:append:am62xx() {
>> +    install -d ${D}/boot
>> +    install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${D}/boot
>> +}
>> +
>> +do_deploy:append:am62xx() {
>> +    install -d ${DEPLOYDIR}
>> +    install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz 
>> ${DEPLOYDIR}
> 
> Any specific reason you also need to deploy this loose file?
> 

I think the boot partition script which is ran as part of do_image_wic expects
IMAGE_BOOTFILES to be present in deploy directory, I remember getting below
error without doing so :

| ERROR: _exec_cmd: install -m 0644 -D
/home/devarsht/ti/yocto_sdk_am62/oe-layersetup/build/arago-tmp-default-glibc/deploy/images/am62xx-evm/ti.gz
/home/devarsht/ti/yocto_sdk_am62/oe-layersetup/build/arago-tmp-default-glibc/work/am62xx_evm-oe-linux/tisdk-default-image/1.0-r0/tmp-wic/hdd/boot/ti.gz
returned '1' instead of 0
| output: install: cannot stat
'/home/devarsht/ti/yocto_sdk_am62/oe-layersetup/build/arago-tmp-default-glibc/deploy/images/am62xx-evm/ti.gz':
No such file or directory
| WARNING:
/home/devarsht/ti/yocto_sdk_am62/oe-layersetup/build/arago-tmp-default-glibc/work/am62xx_evm-oe-linux/tisdk-default-image/1.0-r0/temp/run.do_image_wic.1581619:162
exit 1 from 'BUILDDIR="/home/devarsht/ti/yocto_sdk_am62/oe-layersetup/build"
PSEUDO_UNLOAD=1 wic create "$wks" --vars
"/home/devarsht/ti/yocto_sdk_am62/oe-layersetup/build/arago-tmp-default-glibc/sysroots/am62xx-evm/imgdata/"
-e "tisdk-default-image" -o "$build_wic/" -w "$tmp_wic"'


One more reason to do so was to allow user ease of use, to copy the logo too
from deploy folder along with other boot files (if not flashing from wic
image) since the same is set in am62x.env and if logo is not present in boot
partition then it throws some error message although the device still boots.

Regards
Devarsh
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16723): 
https://lists.yoctoproject.org/g/meta-ti/message/16723
Mute This Topic: https://lists.yoctoproject.org/mt/99528771/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to