Hi Ricardo, On 12:13-20230614, Ricardo Salveti wrote: > On Wed, Jun 14, 2023 at 4:41 AM Manorit Chawdhry via > lists.yoctoproject.org <[email protected]> > wrote: > > > > Enables FIT Image signing for K3 platforms > > > > Signed-off-by: Manorit Chawdhry <[email protected]> > > --- > > meta-ti-bsp/conf/machine/include/k3.inc | 7 +++++++ > > meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_6.1.bb | 1 + > > 2 files changed, 8 insertions(+) > > > > diff --git a/meta-ti-bsp/conf/machine/include/k3.inc > > b/meta-ti-bsp/conf/machine/include/k3.inc > > index f8bfb3dbcafc..eb25fa780407 100644 > > --- a/meta-ti-bsp/conf/machine/include/k3.inc > > +++ b/meta-ti-bsp/conf/machine/include/k3.inc > > @@ -31,6 +31,13 @@ SPL_BINARY = "tispl.bin" > > SPL_BINARYNAME = "tispl.bin" > > UBOOT_SUFFIX = "img" > > > > +UBOOT_SIGN_ENABLE = "1" > > +UBOOT_MKIMAGE_DTCOPTS = "-I dts -O dtb" > > +UBOOT_SIGN_KEYNAME ?= "custMpk" > > +UBOOT_SIGN_KEYDIR ?= "${TI_SECURE_DEV_PKG}/keys" > > Did you verify that this won't cause a build failure when the key is > not available at runtime (e.g. users not defining TI_SECURE_DEV_PKG)? > > Just because UBOOT_SIGN_ENABLE is being forced to 1. >
TI_SECURE_DEV_PKG will always be set whenever we inherit ti-secdev recipe and that is being done in the linux recipe in the same patch. The kernel recipe internally uses this variable so no one should be required to set this explicitely and the build had passed. Though on the other hand, the build still passes even in we provide a wrong folder if I understand correctly and the generate images don't have the signature. Though I had validated this change on my local setup and could see the things working as expected. Regards, Manorit > Thanks, > -- > Ricardo Salveti
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16729): https://lists.yoctoproject.org/g/meta-ti/message/16729 Mute This Topic: https://lists.yoctoproject.org/mt/99523231/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
