On 9/11/23 10:35 PM, Denys Dmytriyenko wrote:
> On Mon, Sep 11, 2023 at 09:58:23AM +0530, Ravi Gunasekaran via 
> lists.yoctoproject.org wrote:
>> Andrew,
>>
>> On 9/8/23 7:49 PM, Andrew Davis wrote:
>>> On 9/8/23 6:44 AM, Ravi Gunasekaran via lists.yoctoproject.org wrote:
>>>> Remove the PRU Ethernet firmwares from being packaged for
>>>> AM33x, AM43x and AM57x.
>>>>
>>>
>>> Commit messages should give the "why", we can read the code.
>>
>> I will provide reasoning in the v2.
>>
>>>
>>> Are we dropping support for PRUETH from these boards? I still
>>> use this, I'm sure others do too.
>>>
>>
>> PRUETH drivers for these devices are not upstreamed and PRUTETH will not
>> be supported in SDK 9.1 as well. Plan to upstream and port to SDK is still
>> being worked on. So I wanted to remove these firmwares from being packaged.
> 
> So, besides PRU ETH, what about SW, HSR and PRP firmwares that are being 
> removed here?

Ah ok. I get your perspective.

SW, HSR and PRP are different ethernet modes and they have their respective 
firmwares.
In driver space, it is just PRUETH driver and it loads different types of 
ethernet
firmware based on the configuration. I used PRUETH as an umbrella term as 
that's what
is used in our documentation. 

Based on Ryan's feedback on the approach to remove these firmwares,
I will reword the commit message to give this view in v2


> 
> 
>>>> Signed-off-by: Ravi Gunasekaran <[email protected]>
>>>> ---
>>>> Changes from v1:
>>>> --------------
>>>> * Corrected the commit message.
>>>>
>>>>   meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 ---
>>>>   1 file changed, 3 deletions(-)
>>>>
>>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc 
>>>> b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc
>>>> index 266a7ef5..317ab1b1 100644
>>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc
>>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc
>>>> @@ -12,9 +12,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " 
>>>> vpdma-fw"
>>>>   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:dra7xx = " goodix-fw"
>>>>     # Add run-time dependency for PRU Ethernet firmware to the rootfs
>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am57xx = " prueth-fw prusw-fw 
>>>> pruhsr-fw pruprp-fw"
>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti43x = " prueth-fw pruhsr-fw 
>>>> pruprp-fw"
>>>> -RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:ti33x = " prueth-fw pruhsr-fw 
>>>> pruprp-fw"
>>>>   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx = " prueth-fw-am65x"
>>>>   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am65xx-evm = " 
>>>> prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2"
>>>>   RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am64xx = " 
>>>> prueth-fw-am65x-sr2 pruhsr-fw-am65x-sr2 prusw-fw-am65x-sr2"
>>>>
>>>> base-commit: c3916324a01fe96c68a78ef9ed0070d6b1fc8f2f

-- 
Regards,
Ravi
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16952): 
https://lists.yoctoproject.org/g/meta-ti/message/16952
Mute This Topic: https://lists.yoctoproject.org/mt/101234600/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to