On 7/9/2024 2:58 AM, Siddharth Vadapalli wrote:
On Mon, Jul 08, 2024 at 09:04:43AM -0500, Ryan Eatmon wrote:

[...]

diff --git a/meta-ti-bsp/conf/machine/am62pxx-evm-k3r5.conf 
b/meta-ti-bsp/conf/machine/am62pxx-evm-k3r5.conf
index 36915381..9b68e626 100644
--- a/meta-ti-bsp/conf/machine/am62pxx-evm-k3r5.conf
+++ b/meta-ti-bsp/conf/machine/am62pxx-evm-k3r5.conf
@@ -10,3 +10,4 @@ SYSFW_CONFIG = "evm"
   SYSFW_SUFFIX = "hs-fs"
   UBOOT_MACHINE = "am62px_evm_r5_defconfig"
+UBOOT_CONFIG_FRAGMENTS = "am62x_r5_usbdfu.config"
For this one, there are already UBOOT_CONFIG_FRAGMENTS later in the file
that you are not taking into account by just setting the variable.  This
file is going to be a little more difficult to do correctly.

Since we already have a setting with an override, I think the best plan
would be to rework the existing logic while adding your changes.  Add some
intermediate variables to construct the final value.  Something like this:

BASE_FRAGMENTS = "am62x_r5_usbdfu.config"
BASE_FRAGMENTS:ti-bsp-6_1 = ""

# UBOOT_CONFIG_FRAGMENTS holds the list of u-boot config fragments which has
to be build
# along with the base defconfig mentioned in UBOOT_MACHINE. Refer
u-boot-mergeconfig.inc
# under meta-ti-bsp/recipes-bsp/u-boot/ for more details.
# For AM62P tisdk-display-cluster image, splash screen is handled by SBL.
# Hence, disable the A53 based splash screen using the
am62x_evm_prune_splashscreen.config fragment present in ti-u-boot tree
PRUNE_SPLASHSCREEN_FRAGMENT =
"${@oe.utils.conditional('DISPLAY_CLUSTER_ENABLE', '1',
'am62x_evm_prune_splashscreen.config', '', d)}"
PRUNE_SPLASHSCREEN_FRAGMENT :bsp-ti-6_1 =
"${@oe.utils.conditional('DISPLAY_CLUSTER_ENABLE', '1',
'am62px_evm_prune_splashscreen.config', '', d)}"

UBOOT_CONFIG_FRAGMENTS = " $(BASE_FRAGMENTS) $(PRUNE_SPLASHSCREEN_FRAGMENT)"

I failed to notice it in my earlier response. The above file that you
are referring to is different from the one that this patch modifies.
This patch is updating:
meta-ti-bsp/conf/machine/am62pxx-evm-k3r5.conf
while the file that you are referring to above is:
meta-ti-bsp/conf/machine/am62pxx-evm.conf

So
UBOOT_CONFIG_FRAGMENTS = "am62x_r5_usbdfu.config"
UBOOT_CONFIG_FRAGMENTS:bsp-ti-6_1 = ""
is applicable to this as well, similar to other files.
I will implement the above change uniformly across all files in the v4
patch.

Good point.  I looked in the wrong file when I was looking in the files.


[...]

Regards,
Siddharth.

--
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17846): 
https://lists.yoctoproject.org/g/meta-ti/message/17846
Mute This Topic: https://lists.yoctoproject.org/mt/107101381/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to