Re: [meta-ti][master][PATCH] libdce: Fix compile errors

[Ryan Eatmon via lists.yoctoproject.org]

On 1/9/2025 1:50 PM, Chirag Shilwant wrote:
Hi,
On 09/01/25 22:46, Ryan Eatmon via lists.yoctoproject.org wrote:
Added a patch to fix some compile errors: .. /git/memplugin_linux. c: 
In function 'memplugin_alloc': .. /git/memplugin_linux. c: 69: 9: 
error: implicit declaration of function 'dsp_dce_buf_lock' 
[-Wimplicit-function-declaration] 69 | dsp_dce_buf_lock(1,
ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source 
of this email and know the content is safe.
Report Suspicious
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uHdqXRfP1m07KyZE3PNDfMzpulZCOH34hVMNBCLRBdzFbdBs5l1f-3NAfQSc-GHKWgxxiFjmDJES7cQVnA$>
ZjQcmQRYFpfptBannerEnd
Added a patch to fix some compile errors:



Any particular reasons for fixing the compilation error via a patch
rather than updating the sources itself since it lies under git.ti.com [1]

Because that repo hasn't been updated in 7 years.  If we want to work on 
getting it updated, then we can remove the patch.  But we have a build 
failure today that we need to resolve.


[1]: https://git.ti.com/cgit/omapzoom/libdce/

--
Chirag




../git/memplugin_linux.c: In function 'memplugin_alloc':
../git/memplugin_linux.c:69:9: error: implicit declaration of function 
'dsp_dce_buf_lock' [-Wimplicit-function-declaration]
    69 |         dsp_dce_buf_lock(1, &(h->dma_buf_fd));
       |         ^~~~~~~~~~~~~~~~
../git/memplugin_linux.c:71:9: error: implicit declaration of function 
'dce_buf_lock' [-Wimplicit-function-declaration]
    71 |         dce_buf_lock(1, &(h->dma_buf_fd));
       |         ^~~~~~~~~~~~
../git/memplugin_linux.c: In function 'memplugin_free':
../git/memplugin_linux.c:91:17: error: implicit declaration of 
function 'dsp_dce_buf_unlock' [-Wimplicit-function-declaration]
    91 |                 dsp_dce_buf_unlock(1, &(h->dma_buf_fd));
       |                 ^~~~~~~~~~~~~~~~~~
../git/memplugin_linux.c:93:17: error: implicit declaration of 
function 'dce_buf_unlock' [-Wimplicit-function-declaration]
    93 |                 dce_buf_unlock(1, &(h->dma_buf_fd));
       |                 ^~~~~~~~~~~~~~
../git/memplugin_linux.c:95:13: error: implicit declaration of 
function 'close'; did you mean 'pclose'? 
[-Wimplicit-function-declaration]
    95 |             close(h->dma_buf_fd);
       |             ^~~~~
       |             pclose

and

../git/libdce_linux.c: In function 'dce_deinit':
../git/libdce_linux.c:90:9: error: implicit declaration of function 
'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
    90 |         close(OmapDrm_FD);
       |         ^~~~~
       |         pclose

Signed-off-by: Ryan Eatmon <reat...@ti.com>
---
  .../files/0001-linux-Fix-compile-errors.patch | 70 +++++++++++++++++++
  .../libdce/libdce_3.00.15.00.bb               |  5 +-
  2 files changed, 74 insertions(+), 1 deletion(-)
  create mode 100644 
meta-ti-extras/recipes-multimedia/libdce/files/0001-linux-Fix-compile-errors.patch

diff --git 
a/meta-ti-extras/recipes-multimedia/libdce/files/0001-linux-Fix-compile-errors.patch b/meta-ti-extras/recipes-multimedia/libdce/files/0001-linux-Fix-compile-errors.patch
new file mode 100644
index 00000000..aaee694d
--- /dev/null
+++ 
b/meta-ti-extras/recipes-multimedia/libdce/files/0001-linux-Fix-compile-errors.patch
@@ -0,0 +1,70 @@
+From 23db5f29715b771b8557703f1eea7f1502796d5d Mon Sep 17 00:00:00 2001
+From: Ryan Eatmon <reat...@ti.com>
+Date: Thu, 9 Jan 2025 10:34:17 -0600
+Subject: [PATCH] linux: Fix compile errors
+
+Fix the following compile errors:
+
+../git/memplugin_linux.c:69:9: error: implicit declaration of 
function 'dsp_dce_buf_lock' [-Wimplicit-function-declaration]
+   69 |         dsp_dce_buf_lock(1, &(h->dma_buf_fd));
+      |         ^~~~~~~~~~~~~~~~
+../git/memplugin_linux.c:71:9: error: implicit declaration of 
function 'dce_buf_lock' [-Wimplicit-function-declaration]
+   71 |         dce_buf_lock(1, &(h->dma_buf_fd));
+      |         ^~~~~~~~~~~~
+../git/memplugin_linux.c: In function 'memplugin_free':
+../git/memplugin_linux.c:91:17: error: implicit declaration of 
function 'dsp_dce_buf_unlock' [-Wimplicit-function-declaration]
+   91 |                 dsp_dce_buf_unlock(1, &(h->dma_buf_fd));
+      |                 ^~~~~~~~~~~~~~~~~~
+../git/memplugin_linux.c:93:17: error: implicit declaration of 
function 'dce_buf_unlock' [-Wimplicit-function-declaration]
+   93 |                 dce_buf_unlock(1, &(h->dma_buf_fd));
+      |                 ^~~~~~~~~~~~~~
+../git/memplugin_linux.c:95:13: error: implicit declaration of 
function 'close'; did you mean 'pclose'? 
[-Wimplicit-function-declaration]
+   95 |             close(h->dma_buf_fd);
+      |             ^~~~~
+      |             pclose
+
+and
+
+../git/libdce_linux.c: In function 'dce_deinit':
+../git/libdce_linux.c:90:9: error: implicit declaration of function 
'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
+   90 |         close(OmapDrm_FD);
+
+Signed-off-by: Ryan Eatmon <reat...@ti.com>
+
+Upstream-Status: Pending
+
+---
+ libdce_linux.c    | 2 ++
+ memplugin_linux.c | 2 ++
+ 2 files changed, 4 insertions(+)
+
+diff --git a/libdce_linux.c b/libdce_linux.c
+index 8bae002..6e4f63d 100644
+--- a/libdce_linux.c
++++ b/libdce_linux.c
+@@ -45,6 +45,8 @@
+ #include "dce_rpc.h"
+ #include "memplugin.h"
+
++#include <unistd.h>
++
+ #define INVALID_DRM_FD (-1)
+
+ static int             OmapDrm_FD  = INVALID_DRM_FD;
+diff --git a/memplugin_linux.c b/memplugin_linux.c
+index 5543a68..59b3658 100644
+--- a/memplugin_linux.c
++++ b/memplugin_linux.c
+@@ -33,6 +33,9 @@
+ #include "memplugin.h"
+ #include "dce_priv.h"
+
++#include "libdce.h"
++#include <unistd.h>
++
+ extern struct omap_device   *OmapDev;
+
+
+--
+2.17.1
+
diff --git 
a/meta-ti-extras/recipes-multimedia/libdce/libdce_3.00.15.00.bb 
b/meta-ti-extras/recipes-multimedia/libdce/libdce_3.00.15.00.bb
index f46d9c77..998d3ff6 100644
--- a/meta-ti-extras/recipes-multimedia/libdce/libdce_3.00.15.00.bb
+++ b/meta-ti-extras/recipes-multimedia/libdce/libdce_3.00.15.00.bb
@@ -6,7 +6,10 @@ inherit autotools pkgconfig
  DEPENDS = "libdrm ti-ipc"
-SRC_URI = 
"git://git.ti.com/git/omapzoom/libdce.git;protocol=https;branch=master"
+SRC_URI = "\
+    
git://git.ti.com/git/omapzoom/libdce.git;protocol=https;branch=master \
+    file://0001-linux-Fix-compile-errors.patch \
+"
  SRCREV = "ec14e1d5cea1ed3c3ea0e2b9cf1fd581acff93e3"
--
2.17.1





--
Ryan Eatmon                reat...@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18175): 
https://lists.yoctoproject.org/g/meta-ti/message/18175
Mute This Topic: https://lists.yoctoproject.org/mt/110519894/21656
Group Owner: meta-ti+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-