Please send patches inline to make review easier.

Patch 1:

> * Add PR_append

Don't do that, that's what PRINC is for

> * Pull in the base interface file from oe-core

Completely unneeded

> * Update to use the new syntax for extending the file search path

Patch 2:

> Update interface file based on changes made to the interface file
  in arago

THe interfaces file is supposed to be machine specific, so a "one file to rule 
them all" is completely unacceptable in meta-ti. If you want to go such a 
route, do it in meta-arago. Even so, I strongly recommend against that.

Op 1 aug. 2012, om 21:07 heeft "Cooper Jr., Franklin" <[email protected]> het 
volgende geschreven:

> Attached patches are for porting the netbase interface file used in 
> arago/oe-classic to meta-ti.
>  
> The difference between my interfaces file and the one in beagleboard 
> directory seems very minor. Would it be ok to combine the changes from both 
> files into a single file? The auto usb0 looks like it might be an issue if we 
> combined the two files. Would it make sense to append that line to the 
> interface file during do_install_append step only for the beagleboard 
> platform and consolidate the rest of the differences?
>  
> diff beagleboard/interfaces interfaces
> 13a14,17
> > iface tiwlan0 inet dhcp
> >    wireless_mode managed
> >    wireless_essid any
> >
> 18a23,24
> >         pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-9]\+\.[0-9]\+" 
> > /proc/cmdline > /dev/null
> >
> 21,22c27,28
> < # Ethernet/RNDIS gadget (g_ether) or LAN9514 on BeagleBoard xM
> < auto usb0
> ---
> > # Ethernet/RNDIS gadget (g_ether)
> > # ... or on host side, usbnet and random hwaddr
>  
>  
> Regards,
> Franklin Cooper Jr.
> Texas Instruments
> Application Engineer
> [email protected]
>  
> <0001-netbase-Add-base-interface-file.patch><0002-netbase-Update-interface-file.patch>_______________________________________________
> meta-ti mailing list
> [email protected]
> https://lists.yoctoproject.org/listinfo/meta-ti

_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

Reply via email to