Hello Denys, Any update on below ?
>> You should probably squash those patches then. I can, with some rework. Please let me know your preference, regards, Prabu -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Sundareson, Prabindh Sent: Thursday, May 30, 2013 9:03 AM To: Dmytriyenko, Denys Cc: [email protected] Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package Hello Denys, >> You should probably squash those patches then. I can, with some rework. Please let me know your preference, >> Have you tried passing -M to git-format-patch? No. I read through the submission guidelines, and I did not see anything specific there. How does this help ? Or did you mean this in the context of the squashing ? regards, Prabu -----Original Message----- From: Dmytriyenko, Denys Sent: Thursday, May 30, 2013 8:51 AM To: Sundareson, Prabindh Cc: [email protected] Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package On Wed, May 29, 2013 at 11:18:36PM -0400, Sundareson, Prabindh wrote: > Denys, > > Thanks for reviewing, > > It is a simple correction. I had mistakenly removed it in the first > one, and reinstated in the next one after comparing with the original > patch-set. Is there anything missing you observe ? You should probably squash those patches then. Otherwise look fine - I just need to diff the first patch in the series against the original. Have you tried passing -M to git-format-patch? -- Denys > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Thursday, May 30, 2013 2:47 AM > To: Sundareson, Prabindh > Cc: [email protected] > Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary > inclusion of folders into package > > On Fri, May 17, 2013 at 10:27:56PM +0530, Prabindh Sundareson wrote: > > Inclusion of all .so files is not necessary for the package build. > > > > Signed-off-by: Prabindh Sundareson <[email protected]> > > --- > > recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ---- > > 1 files changed, 0 insertions(+), 4 deletions(-) > > > > diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc > > b/recipes-graphics/libgles/libgles-omap3-no-x.inc > > index 8e5dad6..4521d59 100644 > > --- a/recipes-graphics/libgles/libgles-omap3-no-x.inc > > +++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc > > @@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags" > > INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags" > > INSANE_SKIP_${PN}-tests = "ldflags" > > > > -# Quality control is really poor on these SDKs, so hack around the latest > > madness: > > -FILES_${PN} += "${libdir}/*.so " > > -FILES_${PN}-dev = "${includedir}" > > I'm confused - you are removing these 2 lines in 7/10 and then immediately > re-add them back in 8/10. Why? > > > > inherit update-rc.d > > > > INITSCRIPT_NAME = "pvr-init" > > -- > > 1.7.1 > > > > _______________________________________________ > > meta-ti mailing list > > [email protected] > > https://lists.yoctoproject.org/listinfo/meta-ti _______________________________________________ meta-ti mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-ti _______________________________________________ meta-ti mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-ti
