Hi Denys,

I have reworked the patches to address all your comments.
Regarding the license, I looked into the ti-cgt-arm folder after extraction, it has mention of all these licenses that are captured in the recipe.

The v2 of the patch set has been validated with the latest morty/morty-next.

Regards
Karthik

On 20-Apr-17 1:13 AM, Denys Dmytriyenko wrote:
Please see inline.


On Wed, Apr 19, 2017 at 04:00:01PM +0530, Karthik Ramanan wrote:
From: Ivan Pang <[email protected]>

Signed-off-by: Ivan Pang <[email protected]>
Signed-off-by: Karthik Ramanan <[email protected]>
---
  classes/component_meta.bbclass          | 29 +++++++++++++++++++++++++++++
  recipes-ti/devtools/ti-cgt-arm-linux.bb | 26 ++++++++++++++++++++++++++
  recipes-ti/devtools/ti-cgt-arm.bb       | 26 ++++++++++++++++++++++++++
  recipes-ti/devtools/ti-cgt-arm.inc      | 19 +++++++++++++++++++
  4 files changed, 100 insertions(+)
  create mode 100644 classes/component_meta.bbclass
  create mode 100644 recipes-ti/devtools/ti-cgt-arm-linux.bb
  create mode 100644 recipes-ti/devtools/ti-cgt-arm.bb
  create mode 100644 recipes-ti/devtools/ti-cgt-arm.inc

diff --git a/classes/component_meta.bbclass b/classes/component_meta.bbclass
new file mode 100644
index 0000000..f2dc754
--- /dev/null
+++ b/classes/component_meta.bbclass
@@ -0,0 +1,29 @@
+CM_NAME ?= ""
+CM_VERSION ?= ""
+CM_ROOT_DIR ?= ""
+CM_BINARY ?= ""
+CM_DESCRIPTION ?= ""
I'm not sure what's the purpose of this class and why you are including it
here...
I'd suggest you drop it completely.


+do_component_meta() {
+    if [ ! -d "${DEPLOY_DIR_IMAGE}" ]
+    then
+        mkdir -p ${DEPLOY_DIR_IMAGE}
+    fi
+
+    if [ ! -e "${DEPLOY_DIR_IMAGE}/.components_meta" ]
+    then
+        touch ${DEPLOY_DIR_IMAGE}/.components_meta
+    fi
+
+    # Check if component is already documented in .components_meta
+    if ! grep -q "${CM_ROOT_DIR}" ${DEPLOY_DIR_IMAGE}/.components_meta
+    then
+        # Add component meta information
+        echo 
"${CM_NAME}|${CM_VERSION}|${CM_ROOT_DIR}|${CM_BINARY}|${CM_DESCRIPTION}" >> \
+            ${DEPLOY_DIR_IMAGE}/.components_meta
+    fi
+}
+
+do_component_meta[lockfiles] = "${DEPLOY_DIR_IMAGE}/component_meta.lock"
+
+addtask do_component_meta after do_install before do_package
diff --git a/recipes-ti/devtools/ti-cgt-arm-linux.bb 
b/recipes-ti/devtools/ti-cgt-arm-linux.bb
new file mode 100644
index 0000000..dbb143c
--- /dev/null
+++ b/recipes-ti/devtools/ti-cgt-arm-linux.bb
@@ -0,0 +1,26 @@
+include ti-cgt-arm.inc
+
+BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin"
+BINFILE_MD5 = "aa65a078eeddbf10e8e132a4cf1d58f0"
+BINFILE_SHA256 = 
"a372fd6f7b2608e11326b5c7438311aa37c7fbca0728b158cb9064a0666a8a05"
+
+do_install() {
+    cp ${S}/../${BINFILE} ${S}/${BINFILE_NAME}
Why do you need this step?

In general, what's the difference between ti-cgt-arm-linux.bb and ti-cgt-arm.bb?

Anyway, this ti-cgt-arm-linux recipe looks superflous to me...


+}
+
+inherit component_meta
+CM_NAME = "TI CGT ARM"
+CM_VERSION = "${PV}"
+CM_ROOT_DIR = "ti-cgt-arm_${PV}"
+CM_DESCRIPTION = "TI ARM code generation tools, including C/C++ compiler, linker, 
and run-time-support libraries"
+CM_BINARY = "${BINFILE_NAME}"
+
+deltask do_create_srcipk
+addtask create_srcipk after do_install before do_populate_sysroot
+
+CREATE_SRCIPK = "1"
+SRCIPK_INSTALL_DIR = "${CM_ROOT_DIR}"
+SRCIPK_SRC_DIR = "${S}"
This should not be here! This has nothing to do with meta-ti!


+INHIBIT_PACKAGE_STRIP = "1"
+INHIBIT_SYSROOT_STRIP = "1"
diff --git a/recipes-ti/devtools/ti-cgt-arm.bb 
b/recipes-ti/devtools/ti-cgt-arm.bb
new file mode 100644
index 0000000..464374d
--- /dev/null
+++ b/recipes-ti/devtools/ti-cgt-arm.bb
@@ -0,0 +1,26 @@
+include ti-cgt-arm.inc
+
+S = "${WORKDIR}/ti-cgt-arm-${PV}"
May need to be set in .inc file...


+require recipes-ti/includes/ti-unpack.inc
+require recipes-ti/includes/ti-staging.inc
+require recipes-ti/includes/ti-paths.inc
+
+TI_BIN_UNPK_ARGS = "--prefix ${S}"
+TI_BIN_UNPK_CMDS = ""
+
+BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin"
+BINFILE_MD5 = "aa65a078eeddbf10e8e132a4cf1d58f0"
+BINFILE_SHA256 = 
"a372fd6f7b2608e11326b5c7438311aa37c7fbca0728b158cb9064a0666a8a05"
+
+do_install() {
+    install -d ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}
+    cp -r ${S}/ti-cgt-arm*/. ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}
+}
+
+FILES_${PN} += "${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}"
+
+BBCLASSEXTEND = "native nativesdk"
+
+INHIBIT_PACKAGE_STRIP = "1"
+INHIBIT_SYSROOT_STRIP = "1"
diff --git a/recipes-ti/devtools/ti-cgt-arm.inc 
b/recipes-ti/devtools/ti-cgt-arm.inc
new file mode 100644
index 0000000..195d59e
--- /dev/null
+++ b/recipes-ti/devtools/ti-cgt-arm.inc
@@ -0,0 +1,19 @@
+DESCRIPTION = "TI ARM Code Generation Tools"
Use SUMMARY


+HOMEPAGE = 
"https://www-a.ti.com/downloads/sds_support/TICodegenerationTools/download.htm";
+LICENSE = "(TI-TSPA & Thai-Open-Source-Software-Center) & BSD-3-Clause & BSL-1.0 & Hewlett-Packard 
& AFL-3.0 & MIT & BSD-2-Clause & PD & BSD-4-Clause"
Is this the correct license?


+LIC_FILES_CHKSUM = "file://../${BINFILE};md5=${BINFILE_MD5}"
This is very incorrect! Please point to the real license file.


+PV = "16.9.1"
+PE = "0"
Drop this - 0 is the default.


+BINFILE_NAME = "cgt_arm_installer"
+
+SRC_URI = 
"http://software-dl.ti.com/codegen/esd/cgt_public_sw/TMS470/${PV}.LTS/${BINFILE};name=${BINFILE_NAME}";
+
+SRC_URI[cgt_arm_installer.md5sum] = "${BINFILE_MD5}"
+SRC_URI[cgt_arm_installer.sha256sum] = "${BINFILE_SHA256}"
+
+FILES_${PN} += "${S}/*"
??? What's this?


+INSANE_SKIP_${PN} += "arch staticdev"
--
1.9.1

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

Reply via email to