Karthik, Denys, >> +PV = "16.9.2" > Would it be better to have this in the recipe filename? I'm not sure if > there is a preference.
Sorry, I haven't kept up with the patch mails. There was a specific reason I moved the PV out of the filename and into the .inc file - I had multiple recipes in RTOS that would need to align with this PV (see ti-cgt-arm-linux.bb and ti-cgt-arm-windows.bb). This would let us update only the .inc file whenever we want to bump up the version. Ivan -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Dmytriyenko, Denys Sent: Tuesday, April 25, 2017 6:19 PM To: R, Karthik Cc: [email protected] Subject: Re: [meta-ti] [morty v3 1/3] ti-cgt-arm: add recipe for 16.9.2 Karthik, This looks much better! I would have said there's no reason to split it into a recipe and .inc anymore, but we'll probably also need a -nativesdk recipe, so keeping .inc for now. There are couple cosmetic nitpicks - there's no space between SUMMARY and = sign; and BINFILE variable is defined twice. I'll fix those on merge though. -- Denys On Tue, Apr 25, 2017 at 04:56:02PM +0530, Karthik Ramanan wrote: > Signed-off-by: Karthik Ramanan <[email protected]> > --- > recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb | 8 ++++++ > recipes-ti/devtools/ti-cgt-arm.inc | 35 > +++++++++++++++++++++++++ > 2 files changed, 43 insertions(+) > create mode 100644 recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb > create mode 100644 recipes-ti/devtools/ti-cgt-arm.inc > > diff --git a/recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb > b/recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb > new file mode 100644 > index 0000000..c4fc7f0 > --- /dev/null > +++ b/recipes-ti/devtools/ti-cgt-arm-native_16.9.2.bb > @@ -0,0 +1,8 @@ > +include ti-cgt-arm.inc > + > +LIC_FILES_CHKSUM = > "file://ti-cgt-arm_${PV}.LTS/README.txt;md5=c32eadd03472353c042a8a7c4568438b" > + > +BINFILE_MD5 = "7b73e51e9548a4a0bf3923a336b1a974" > +BINFILE_SHA256 = > "d1a5c255319088be7d75b3fce1b16a2e3d60c75023db7dad16cab6d4d3425d06" > + > +PR_append = "r2" > diff --git a/recipes-ti/devtools/ti-cgt-arm.inc > b/recipes-ti/devtools/ti-cgt-arm.inc > new file mode 100644 > index 0000000..8cc1ca4 > --- /dev/null > +++ b/recipes-ti/devtools/ti-cgt-arm.inc > @@ -0,0 +1,35 @@ > +SUMMARY= "TI ARM Code Generation Tools" > +HOMEPAGE = > "https://www-a.ti.com/downloads/sds_support/TICodegenerationTools/download.htm"; > +LICENSE = "(TI-TSPA & Thai-Open-Source-Software-Center) & BSD-3-Clause & > BSL-1.0 & Hewlett-Packard & AFL-3.0 & MIT & BSD-2-Clause & PD & BSD-4-Clause" > + > +inherit native > +require recipes-ti/includes/ti-unpack.inc > +require recipes-ti/includes/ti-staging.inc > +require recipes-ti/includes/ti-paths.inc > + > +S = "${WORKDIR}/ti-cgt-arm-${PV}" > + > +SRC_URI = > "http://software-dl.ti.com/codegen/esd/cgt_public_sw/TMS470/${PV}.LTS/${BINFILE};name=${BINFILE_NAME}"; > + > +BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin" > +TI_BIN_UNPK_ARGS = "--prefix ${S}" > +TI_BIN_UNPK_CMDS = "" > + > +do_install() { > + install -d ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE} > + cp -r ${S}/ti-cgt-arm*/. ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE} > +} > + > +SRC_URI[cgt_arm_installer.md5sum] = "${BINFILE_MD5}" > +SRC_URI[cgt_arm_installer.sha256sum] = "${BINFILE_SHA256}" > + > +BINFILE_NAME = "cgt_arm_installer" > +BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin" > + > +FILES_${PN} += "${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}" > + > +INHIBIT_PACKAGE_STRIP = "1" > +INHIBIT_SYSROOT_STRIP = "1" > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > + > +INSANE_SKIP_${PN} += "arch staticdev" > -- > 1.9.1 > > -- > _______________________________________________ > meta-ti mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/meta-ti -- _______________________________________________ meta-ti mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-ti -- _______________________________________________ meta-ti mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-ti
