Hi Denys,
Please see the comments inline.
I had submitted the new patch (attached) after addressing the review comments
(v3) and updating the commit message (v4)
Regards
Mahesh
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, August 24, 2017 3:56 PM
To: Radhakrishnan, Mahesh
Cc: [email protected]
Subject: Re: [meta-ti] [PATCH v2 27/37] pruss-lld: Add rtos recipe & update the
version to 1.0.0.7
On Tue, Jul 18, 2017 at 07:03:38PM -0400, Mahesh Radhakrishnan wrote:
> Upstreaming the RTOS low level driver of the PRUSS module & updating
> to the latest version
> Signed-off-by: Mahesh Radhakrishnan
> <[email protected]<mailto:[email protected]>>
> ---
>
> v2 - Added summary
>
> recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb | 23 +++++++++++++++++++++++
> recipes-bsp/pruss-lld/pruss-lld.inc | 8 ++++----
> 2 files changed, 27 insertions(+), 4 deletions(-) create mode 100644
> recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
>
> diff --git a/recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
> b/recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
> new file mode 100644
> index 0000000..5068286
> --- /dev/null
> +++ b/recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
> @@ -0,0 +1,23 @@
> +SUMMARY = "TI RTOS low level driver library for PRUSS"
> +
> +inherit ti-pdk
> +require recipes-bsp/pruss-lld/pruss-lld.inc
> +
> +PR = "${INC_PR}.0"
> +
> +S = "${WORKDIR}/${PRUSS_LLD_GIT_DESTSUFFIX}"
> +
> +DEPENDS_append = " osal-rtos"
> +DEPENDS_append_ti33x = " starterware-rtos"
> +DEPENDS_append_ti43x = " starterware-rtos"
> +
> +# Build with make instead of XDC
> +TI_PDK_XDCMAKE = "0"
> +
> +export PDK_PRUSS_ROOT_PATH ="${WORKDIR}/build"
> +export DEST_ROOT="${WORKDIR}/build"
> +
> +# HTML doc link params
> +PDK_COMP_LINK_TEXT = "PRUSS LLD"
> +
> +INSANE_SKIP_${PN} = "arch"
> diff --git a/recipes-bsp/pruss-lld/pruss-lld.inc
> b/recipes-bsp/pruss-lld/pruss-lld.inc
> index 8620108..1f1bfc5 100644
> --- a/recipes-bsp/pruss-lld/pruss-lld.inc
> +++ b/recipes-bsp/pruss-lld/pruss-lld.inc
> @@ -1,7 +1,7 @@
> LICENSE = "BSD-3-Clause"
> LIC_FILES_CHKSUM =
> "file://pruicss.h;beginline=1;endline=31;md5=315177aa03d58bcd124a6e799e2bd458<file:///\\pruicss.h;beginline=1;endline=31;md5=315177aa03d58bcd124a6e799e2bd458>"
>
> -COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|k2g-evm"
> +COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|k2g-evm|k2g-hs-evm"
That's why you want to use "k2g" SOC family to automatically cover variants.
Updated in the new patch to use k2g
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> PRUSS_LLD_GIT_URI = "git://git.ti.com/keystone-rtos/pruss-lld.git"
> @@ -9,12 +9,12 @@ PRUSS_LLD_GIT_PROTOCOL = "git"
> PRUSS_LLD_GIT_BRANCH = "master"
> PRUSS_LLD_GIT_DESTSUFFIX = "git/ti/drv/pruss"
>
> -# Below commit ID corresponds to "DEV.PRUSS_LLD.01.00.00.06A"
> -PRUSS_LLD_SRCREV = "b98729cc1fc26c9ac32846146892646a23c28adb"
> +# Below commit ID corresponds to "DEV.PRUSS_LLD.01.00.00.07"
> +PRUSS_LLD_SRCREV = "636bb5645014723c54c08245cf8c2ee401eceb4f"
>
> BRANCH = "${PRUSS_LLD_GIT_BRANCH}"
> SRC_URI =
> "${PRUSS_LLD_GIT_URI};destsuffix=${PRUSS_LLD_GIT_DESTSUFFIX};protocol=${PRUSS_LLD_GIT_PROTOCOL};branch=${BRANCH}"
>
> SRCREV = "${PRUSS_LLD_SRCREV}"
> -PV = "01.00.00.06A"
> +PV = "01.00.00.07"
> INC_PR = "r0"
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> [email protected]<mailto:[email protected]>
> https://lists.yoctoproject.org/listinfo/meta-ti
--- Begin Message ---
RTOS low level driver for the PRUSS module
Signed-off-by: Mahesh Radhakrishnan <[email protected]>
---
v4 - Updated the commit message
v3 - Added k2g SOC family in place of k2g-evm & k2g-hs-evm
v2 - Added summary
recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb | 23 +++++++++++++++++++++++
recipes-bsp/pruss-lld/pruss-lld.inc | 8 ++++----
2 files changed, 27 insertions(+), 4 deletions(-)
create mode 100644 recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
diff --git a/recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
b/recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
new file mode 100644
index 0000000..5068286
--- /dev/null
+++ b/recipes-bsp/pruss-lld/pruss-lld-rtos_git.bb
@@ -0,0 +1,23 @@
+SUMMARY = "TI RTOS low level driver library for PRUSS"
+
+inherit ti-pdk
+require recipes-bsp/pruss-lld/pruss-lld.inc
+
+PR = "${INC_PR}.0"
+
+S = "${WORKDIR}/${PRUSS_LLD_GIT_DESTSUFFIX}"
+
+DEPENDS_append = " osal-rtos"
+DEPENDS_append_ti33x = " starterware-rtos"
+DEPENDS_append_ti43x = " starterware-rtos"
+
+# Build with make instead of XDC
+TI_PDK_XDCMAKE = "0"
+
+export PDK_PRUSS_ROOT_PATH ="${WORKDIR}/build"
+export DEST_ROOT="${WORKDIR}/build"
+
+# HTML doc link params
+PDK_COMP_LINK_TEXT = "PRUSS LLD"
+
+INSANE_SKIP_${PN} = "arch"
diff --git a/recipes-bsp/pruss-lld/pruss-lld.inc
b/recipes-bsp/pruss-lld/pruss-lld.inc
index 8620108..44d84b8 100644
--- a/recipes-bsp/pruss-lld/pruss-lld.inc
+++ b/recipes-bsp/pruss-lld/pruss-lld.inc
@@ -1,7 +1,7 @@
LICENSE = "BSD-3-Clause"
LIC_FILES_CHKSUM =
"file://pruicss.h;beginline=1;endline=31;md5=315177aa03d58bcd124a6e799e2bd458"
-COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|k2g-evm"
+COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx-evm|k2g"
PACKAGE_ARCH = "${MACHINE_ARCH}"
PRUSS_LLD_GIT_URI = "git://git.ti.com/keystone-rtos/pruss-lld.git"
@@ -9,12 +9,12 @@ PRUSS_LLD_GIT_PROTOCOL = "git"
PRUSS_LLD_GIT_BRANCH = "master"
PRUSS_LLD_GIT_DESTSUFFIX = "git/ti/drv/pruss"
-# Below commit ID corresponds to "DEV.PRUSS_LLD.01.00.00.06A"
-PRUSS_LLD_SRCREV = "b98729cc1fc26c9ac32846146892646a23c28adb"
+# Below commit ID corresponds to "DEV.PRUSS_LLD.01.00.00.07"
+PRUSS_LLD_SRCREV = "636bb5645014723c54c08245cf8c2ee401eceb4f"
BRANCH = "${PRUSS_LLD_GIT_BRANCH}"
SRC_URI =
"${PRUSS_LLD_GIT_URI};destsuffix=${PRUSS_LLD_GIT_DESTSUFFIX};protocol=${PRUSS_LLD_GIT_PROTOCOL};branch=${BRANCH}"
SRCREV = "${PRUSS_LLD_SRCREV}"
-PV = "01.00.00.06A"
+PV = "01.00.00.07"
INC_PR = "r0"
--
1.9.1
--- End Message ---
--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
