Hi Denys,

Please see my comments inline.

I have submitted a new patch with the fix and an updated commit message 
(attached)



Regards

Mahesh



-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, August 24, 2017 4:12 PM
To: Radhakrishnan, Mahesh
Cc: [email protected]
Subject: Re: [meta-ti] [PATCH v2 35/37] transport-rtos: Added transport 
recipes(bmet, nimu, nimu-icss) for rtos



On Tue, Jul 18, 2017 at 07:03:46PM -0400, Mahesh Radhakrishnan wrote:

> Upstreaming RTOS driver for Network Interface Management Unit

> (NIMU),BMET Ethernet and NIMU ICSS

> Signed-off-by: Mahesh Radhakrishnan 
> <[email protected]<mailto:[email protected]>>

> ---

>

> v2 - Added summary

>

>  recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb  | 21 +++++++++++++++

> recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb | 28 +++++++++++++++++++

>  recipes-bsp/transport-rtos/nimu-rtos_git.bb      | 34 
> ++++++++++++++++++++++++

>  recipes-bsp/transport-rtos/transport.inc         | 17 ++++++++++++

>  4 files changed, 100 insertions(+)

>  create mode 100644 recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb

>  create mode 100644 recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb

>  create mode 100644 recipes-bsp/transport-rtos/nimu-rtos_git.bb

>  create mode 100644 recipes-bsp/transport-rtos/transport.inc

>

> diff --git a/recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb

> b/recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb

> new file mode 100644

> index 0000000..775ef3d

> --- /dev/null

> +++ b/recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb

> @@ -0,0 +1,21 @@

> +SUMMARY = "RTOS driver for BMET Ethernet"

> +

> +inherit ti-pdk

> +require transport.inc

> +

> +PR = "${INC_PR}.0"

> +

> +LIC_FILES_CHKSUM = 
> "file://bmet_transport.h;beginline=12;endline=40;md5=7c7fbe6af03d79b61025a67a8fc96f93<file:///\\bmet_transport.h;beginline=12;endline=40;md5=7c7fbe6af03d79b61025a67a8fc96f93>"

> +

> +COMPATIBLE_MACHINE = "k2hk-evm|k2e-evm|k2l-evm"

> +

> +DEPENDS_append = " qmss-lld-rtos \

> +                   cppi-lld-rtos \

> +"

> +

> +BMET_ETH_DESTSUFFIX = "git/bmet_eth"

> +

> +S = "${WORKDIR}/${BMET_ETH_DESTSUFFIX}"

> +

> +# HTML doc link params

> +PDK_COMP_LINK_TEXT = "Baremetal Ethernet Transport"

> diff --git a/recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb

> b/recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb

> new file mode 100644

> index 0000000..3ca196d

> --- /dev/null

> +++ b/recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb

> @@ -0,0 +1,28 @@

> +SUMMARY = "RTOS driver for NIMU ICSS"

> +

> +inherit ti-pdk

> +require transport.inc

> +

> +PR = "${INC_PR}.0"

> +

> +LIC_FILES_CHKSUM = 
> "file://nimu_icssEth.h;beginline=1;endline=35;md5=fd897e67955a19ba88443d4bc2e7e18a<file:///\\nimu_icssEth.h;beginline=1;endline=35;md5=fd897e67955a19ba88443d4bc2e7e18a>"

> +

> +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k2g|c66x|omapl1"

> +

> +DEPENDS_append = " ti-ndk \



Blocked by ti-ndk

ti-ndk has been pushed now.



> +                   pruss-lld-rtos \

> +                   icss-emac-lld-rtos \ "

> +

> +NIMU_ICSS_DESTSUFFIX = "git/ndk/nimu_icss"

> +

> +# Build with make instead of XDC

> +TI_PDK_XDCMAKE = "0"

> +

> +S = "${WORKDIR}/${NIMU_ICSS_DESTSUFFIX}"

> +

> +export PDK_NIMU_ICSS_ROOT_PATH ="${WORKDIR}/build"

> +export DEST_ROOT="${S}"

> +

> +export NDK_INSTALL_PATH = "${NDK_INSTALL_DIR}"

> +XDCPATH_append = ";${NDK_INSTALL_DIR}/packages"

> diff --git a/recipes-bsp/transport-rtos/nimu-rtos_git.bb

> b/recipes-bsp/transport-rtos/nimu-rtos_git.bb

> new file mode 100644

> index 0000000..0a415ae

> --- /dev/null

> +++ b/recipes-bsp/transport-rtos/nimu-rtos_git.bb

> @@ -0,0 +1,34 @@

> +SUMMARY = "RTOS driver for Network Interface Management Unit (NIMU)"

> +

> +inherit ti-pdk

> +require transport.inc

> +

> +PR = "${INC_PR}.0"

> +

> +LIC_FILES_CHKSUM = 
> "file://nimu_eth.h;beginline=1;endline=35;md5=52ba99291b03b91058e37115b66edb10<file:///\\nimu_eth.h;beginline=1;endline=35;md5=52ba99291b03b91058e37115b66edb10>"

> +

> +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|keystone|c66x|omapl1"

> +

> +NIMU_DESTSUFFIX = "git/ndk/nimu"

> +

> +S = "${WORKDIR}/${NIMU_DESTSUFFIX}"

> +

> +DEPENDS_append = " ti-ndk osal-rtos"

> +DEPENDS_append_ti33x = " starterware-rtos emac-lld-rtos"

> +DEPENDS_append_ti43x = " starterware-rtos emac-lld-rtos"

> +DEPENDS_append_omap-a15 = " emac-lld-rtos"

> +DEPENDS_append_dra7xx-evm = " emac-lld-rtos"



omap-a15 already covers dra7xx-evm.

This has been corrected in the latest patch(V4)



> +DEPENDS_append_keystone = " qmss-lld-rtos cppi-lld-rtos"

> +DEPENDS_append_k2hk-evm = " pa-lld-rtos"

> +DEPENDS_append_k2e-evm = " pa-lld-rtos"

> +DEPENDS_append_k2l-evm = " pa-lld-rtos"

> +DEPENDS_append_k2g = " emac-lld-rtos"

> +

> +# Build with make instead of XDC

> +TI_PDK_XDCMAKE = "0"

> +

> +export PDK_NIMU_ROOT_PATH ="${WORKDIR}/build"

> +export DEST_ROOT="${S}"

> +

> +export NDK_INSTALL_PATH = "${NDK_INSTALL_DIR}"

> +XDCPATH_append = ";${NDK_INSTALL_DIR}/packages"

> diff --git a/recipes-bsp/transport-rtos/transport.inc

> b/recipes-bsp/transport-rtos/transport.inc

> new file mode 100644

> index 0000000..82427fb

> --- /dev/null

> +++ b/recipes-bsp/transport-rtos/transport.inc

> @@ -0,0 +1,17 @@

> +LICENSE = "BSD-3-Clause"

> +

> +PACKAGE_ARCH = "${MACHINE_ARCH}"

> +

> +TRANSPORT_GIT_URI = "git://git.ti.com/keystone-rtos/transport.git"

> +TRANSPORT_GIT_PROTOCOL = "git"

> +TRANSPORT_GIT_BRANCH = "master"

> +

> +# Below commit ID corresponds to "DEV.TRANSPORT.01.00.00.07A"

> +TRANSPORT_SRCREV = "099dbf371cea3b2d883f5c97a4b0e7ef40e84c6a"

> +

> +BRANCH = "${TRANSPORT_GIT_BRANCH}"

> +SRC_URI = 
> "${TRANSPORT_GIT_URI};protocol=${TRANSPORT_GIT_PROTOCOL};branch=${BRANCH}"

> +

> +SRCREV = "${TRANSPORT_SRCREV}"

> +PV = "01.00.00.07A"

> +INC_PR = "r0"

> --

> 1.9.1

>

> --

> _______________________________________________

> meta-ti mailing list

> [email protected]<mailto:[email protected]>

> https://lists.yoctoproject.org/listinfo/meta-ti
--- Begin Message ---
RTOS driver for Network Interface Management Unit
(NIMU),BMET Ethernet and NIMU ICSS
Signed-off-by: Mahesh Radhakrishnan <[email protected]>
---

 v4 - Updated the commit message
 v3 - Removed the redundant DEPENDS for dra7xx-evm
 v2 - Added summary

 recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb  | 21 +++++++++++++++
 recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb | 28 ++++++++++++++++++++
 recipes-bsp/transport-rtos/nimu-rtos_git.bb      | 33 ++++++++++++++++++++++++
 recipes-bsp/transport-rtos/transport.inc         | 17 ++++++++++++
 4 files changed, 99 insertions(+)
 create mode 100644 recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb
 create mode 100644 recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb
 create mode 100644 recipes-bsp/transport-rtos/nimu-rtos_git.bb
 create mode 100644 recipes-bsp/transport-rtos/transport.inc

diff --git a/recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb 
b/recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb
new file mode 100644
index 0000000..775ef3d
--- /dev/null
+++ b/recipes-bsp/transport-rtos/bmet-eth-rtos_git.bb
@@ -0,0 +1,21 @@
+SUMMARY = "RTOS driver for BMET Ethernet"
+
+inherit ti-pdk
+require transport.inc
+
+PR = "${INC_PR}.0"
+
+LIC_FILES_CHKSUM = 
"file://bmet_transport.h;beginline=12;endline=40;md5=7c7fbe6af03d79b61025a67a8fc96f93"
+
+COMPATIBLE_MACHINE = "k2hk-evm|k2e-evm|k2l-evm"
+
+DEPENDS_append = " qmss-lld-rtos \
+                   cppi-lld-rtos \
+"
+
+BMET_ETH_DESTSUFFIX = "git/bmet_eth"
+
+S = "${WORKDIR}/${BMET_ETH_DESTSUFFIX}"
+
+# HTML doc link params
+PDK_COMP_LINK_TEXT = "Baremetal Ethernet Transport"
diff --git a/recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb 
b/recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb
new file mode 100644
index 0000000..3ca196d
--- /dev/null
+++ b/recipes-bsp/transport-rtos/nimu-icss-rtos_git.bb
@@ -0,0 +1,28 @@
+SUMMARY = "RTOS driver for NIMU ICSS"
+
+inherit ti-pdk
+require transport.inc
+
+PR = "${INC_PR}.0"
+
+LIC_FILES_CHKSUM = 
"file://nimu_icssEth.h;beginline=1;endline=35;md5=fd897e67955a19ba88443d4bc2e7e18a"
+
+COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k2g|c66x|omapl1"
+
+DEPENDS_append = " ti-ndk \
+                   pruss-lld-rtos \
+                   icss-emac-lld-rtos \
+"
+
+NIMU_ICSS_DESTSUFFIX = "git/ndk/nimu_icss"
+
+# Build with make instead of XDC
+TI_PDK_XDCMAKE = "0"
+
+S = "${WORKDIR}/${NIMU_ICSS_DESTSUFFIX}"
+
+export PDK_NIMU_ICSS_ROOT_PATH ="${WORKDIR}/build"
+export DEST_ROOT="${S}"
+
+export NDK_INSTALL_PATH = "${NDK_INSTALL_DIR}"
+XDCPATH_append = ";${NDK_INSTALL_DIR}/packages"
diff --git a/recipes-bsp/transport-rtos/nimu-rtos_git.bb 
b/recipes-bsp/transport-rtos/nimu-rtos_git.bb
new file mode 100644
index 0000000..5366da7
--- /dev/null
+++ b/recipes-bsp/transport-rtos/nimu-rtos_git.bb
@@ -0,0 +1,33 @@
+SUMMARY = "RTOS driver for Network Interface Management Unit (NIMU)"
+
+inherit ti-pdk
+require transport.inc
+
+PR = "${INC_PR}.0"
+
+LIC_FILES_CHKSUM = 
"file://nimu_eth.h;beginline=1;endline=35;md5=52ba99291b03b91058e37115b66edb10"
+
+COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|keystone|c66x|omapl1"
+
+NIMU_DESTSUFFIX = "git/ndk/nimu"
+
+S = "${WORKDIR}/${NIMU_DESTSUFFIX}"
+
+DEPENDS_append = " ti-ndk osal-rtos"
+DEPENDS_append_ti33x = " starterware-rtos emac-lld-rtos"
+DEPENDS_append_ti43x = " starterware-rtos emac-lld-rtos"
+DEPENDS_append_omap-a15 = " emac-lld-rtos"
+DEPENDS_append_keystone = " qmss-lld-rtos cppi-lld-rtos"
+DEPENDS_append_k2hk-evm = " pa-lld-rtos"
+DEPENDS_append_k2e-evm = " pa-lld-rtos"
+DEPENDS_append_k2l-evm = " pa-lld-rtos"
+DEPENDS_append_k2g = " emac-lld-rtos"
+
+# Build with make instead of XDC
+TI_PDK_XDCMAKE = "0"
+
+export PDK_NIMU_ROOT_PATH ="${WORKDIR}/build"
+export DEST_ROOT="${S}"
+
+export NDK_INSTALL_PATH = "${NDK_INSTALL_DIR}"
+XDCPATH_append = ";${NDK_INSTALL_DIR}/packages"
diff --git a/recipes-bsp/transport-rtos/transport.inc 
b/recipes-bsp/transport-rtos/transport.inc
new file mode 100644
index 0000000..82427fb
--- /dev/null
+++ b/recipes-bsp/transport-rtos/transport.inc
@@ -0,0 +1,17 @@
+LICENSE = "BSD-3-Clause"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+TRANSPORT_GIT_URI = "git://git.ti.com/keystone-rtos/transport.git"
+TRANSPORT_GIT_PROTOCOL = "git"
+TRANSPORT_GIT_BRANCH = "master"
+
+# Below commit ID corresponds to "DEV.TRANSPORT.01.00.00.07A"
+TRANSPORT_SRCREV = "099dbf371cea3b2d883f5c97a4b0e7ef40e84c6a"
+
+BRANCH = "${TRANSPORT_GIT_BRANCH}"
+SRC_URI = 
"${TRANSPORT_GIT_URI};protocol=${TRANSPORT_GIT_PROTOCOL};branch=${BRANCH}"
+
+SRCREV = "${TRANSPORT_SRCREV}"
+PV = "01.00.00.07A"
+INC_PR = "r0"
--
1.9.1


--- End Message ---
-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

Reply via email to