> -----Original Message----- > From: [email protected] <meta- > [email protected]> On Behalf Of Bruce Ashfield > Sent: den 10 september 2020 02:03 > To: Joe Slater <[email protected]> > Cc: meta-virtualization <[email protected]>; Randy > MacLeod <[email protected]> > Subject: Re: [meta-virtualization] [meta-virt][PATCH 1/1] container-base: > rename recipe > > Except that this breaks existing users. > > We'll leave this as-is.
Well, you could add a new container-base.bb recipe that only does: # This recipe is deprecated. Please use container-base-image instead require container-base-image.bb to care for backwards compatibility. You could also add an anonymous Python function, or probably better, hook into ROOTFS_PREPROCESS_COMMAND, with a bb.warn() about the deprecation state of the old name. Regarding the name of the image recipe, wouldn't "container-image-base" be more in line with existing image recipes? > Bruce > > On Wed, Sep 9, 2020 at 6:03 PM Joe Slater <[email protected]> > wrote: > > > > Change to container-base-image since the convention is to > > have "image" in image recipe names. > > > > Signed-off-by: Joe Slater <[email protected]> > > --- > > recipes-extended/images/{container-base.bb => contain-base-image.bb} | 0 I believe the intended name was "container-base-image.bb"? > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename recipes-extended/images/{container-base.bb => > > contain-base-image.bb} (100%) > > > > diff --git a/recipes-extended/images/container-base.bb > > b/recipes-extended/images/contain-base-image.bb > > similarity index 100% > > rename from recipes-extended/images/container-base.bb > > rename to recipes-extended/images/contain-base-image.bb //Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#5803): https://lists.yoctoproject.org/g/meta-virtualization/message/5803 Mute This Topic: https://lists.yoctoproject.org/mt/76743481/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
