Just do add. I am not sure why the prepend with export LIBRARY_PATH was added to begin with. Perhaps it is no longer required.
-----Original Message----- From: [email protected] <[email protected]> On Behalf Of Ruslan Babayev (fib) via lists.yoctoproject.org Sent: Wednesday, July 21, 2021 1:37 PM To: Bruce Ashfield <[email protected]> Cc: [email protected] Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib". I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like. -----Original Message----- From: Bruce Ashfield <[email protected]> Sent: Wednesday, July 21, 2021 1:32 PM To: Ruslan Babayev (fib) <[email protected]> Cc: [email protected] Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it. Cheers, Bruce On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <[email protected]> wrote: > > Signed-off-by: Ruslan Babayev <[email protected]> > --- > recipes-devtools/python/python3_virtualization.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-devtools/python/python3_virtualization.inc > b/recipes-devtools/python/python3_virtualization.inc > index 55301c7..481db58 100644 > --- a/recipes-devtools/python/python3_virtualization.inc > +++ b/recipes-devtools/python/python3_virtualization.inc > @@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > DEPENDS += " ncurses" > > -do_compile_prepend() { > +do_compile_prepend_class-target() { > export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib > } > > -- > 2.26.2.Cisco > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#6660): https://lists.yoctoproject.org/g/meta-virtualization/message/6660 Mute This Topic: https://lists.yoctoproject.org/mt/84365667/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
