On Sun, Aug 1, 2021 at 8:36 AM Jon Mason <[email protected]> wrote:
>
> I'm building xen-image-minimal for gem5-arm64 machine (in the meta-arm
> layer) and the recent patch to add qemuarm64 support is breaking my
> builds. The patch in question is:
>
> 19347a7c4e4c qemuboot, xen-image-minimal: enable runqemu for qemuarm64
> Xen images
>
> You can see an example of the breakage here:
> https://gitlab.com/jonmason00/meta-arm/-/jobs/1468242014
Hi Jon
I'm sorry that my patch caused trouble and thanks for sending your
report. I now understand the issue.
> The problematic line is
> diff --git a/recipes-extended/images/xen-image-minimal.bb
> b/recipes-extended/images/xen-image-minimal.bb
> index 6733801cca5f..ca6d26836c42 100644
> --- a/recipes-extended/images/xen-image-minimal.bb
> +++ b/recipes-extended/images/xen-image-minimal.bb
> @@ -31,7 +31,7 @@ XEN_PCIBACK_MODULE_x86-64 = "kernel-module-xen-pciback"
>
> LICENSE = "MIT"
>
> -inherit core-image
> +inherit core-image qemuboot-xen-defaults qemuboot-xen-dtb
>
> Reverting this line "fixes" my problem.
Would you be able to try applying this patch instead? I believe it
will resolve the issue.
diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
index 08f9b02..2d37e91 100644
--- a/classes/qemuboot-xen-dtb.bbclass
+++ b/classes/qemuboot-xen-dtb.bbclass
@@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
# Not all architectures qemuboot with a device tree binary, so check
# to see if one is needed. This allows this bbclass file to be used
# in the same image recipe for multiple architectures.
- if [ -n "${QB_DTB}" ] ; then
+ if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
generate_xen_qemuboot_dtb
fi
}
> It seems odd to add qemu
> stuff for machines that don't need it. Is it right to add qemu stuff
> to an image.bb?
I believe that it is reasonable to do so as it enables support for
testing the image (or images derived from it) even if the intended
final target is non-qemu hardware. I have been working on using this
qemu support to enable the OpenEmbedded QA framework to launch a Xen
image and execute standard and Xen-specific OEQA test cases within it,
eg. via: bitbake -c testimage xen-image-minimal
It should be a valuable capability for images that are built even for
non-qemu machine targets. You can also see within this layer that the
xvisor image recipe similarly chooses to include qemu-specific items.
thanks,
Christopher
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6702):
https://lists.yoctoproject.org/g/meta-virtualization/message/6702
Mute This Topic: https://lists.yoctoproject.org/mt/84591911/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
