On Sun, Aug 1, 2021 at 11:49 PM Bruce Ashfield <[email protected]> wrote:
>
> Looks good to me.
>
> I'll wait to hear from Jon that it fixes his problem before merging.

Fix confirmed.  Feel free to add
Reported-and-tested-by: Jon Mason <[email protected]>

:)

>
> Cheers,
>
> Bruce
>
> In message: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build 
> for non-qemuboot-enabled machines
> on 01/08/2021 Christopher Clark wrote:
> > The qemuboot device tree generation task in qemuboot-xen-dtb.bbclass
> > requires the QB_SYSTEM_NAME variable to be set to identify the Qemu
> > binary to use. Skip the task if it is not set.
> >
> > Reported-by: Jon Mason <[email protected]>
> > Signed-off-by: Christopher Clark <[email protected]>
> > ---
> >  classes/qemuboot-xen-dtb.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/classes/qemuboot-xen-dtb.bbclass 
> > b/classes/qemuboot-xen-dtb.bbclass
> > index 08f9b02..2d37e91 100644
> > --- a/classes/qemuboot-xen-dtb.bbclass
> > +++ b/classes/qemuboot-xen-dtb.bbclass
> > @@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
> >      # Not all architectures qemuboot with a device tree binary, so check
> >      # to see if one is needed. This allows this bbclass file to be used
> >      # in the same image recipe for multiple architectures.
> > -    if [ -n "${QB_DTB}" ] ; then
> > +    if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
> >          generate_xen_qemuboot_dtb
> >      fi
> >  }
> > --
> > 2.25.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6711): 
https://lists.yoctoproject.org/g/meta-virtualization/message/6711
Mute This Topic: https://lists.yoctoproject.org/mt/84602607/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to