Hi Bruce, >-----Original Message----- >From: [email protected] <meta- >[email protected]> On Behalf Of Bruce Ashfield via >lists.yoctoproject.org >Sent: 04 May 2022 15:27 >To: Richard Neill <[email protected]> >Cc: [email protected]; nd <[email protected]> >Subject: Re: [meta-virtualization] [PATCH] docker: Add runtime provide for >virtual-docker > >On Wed, May 4, 2022 at 10:09 AM Richard Neill <[email protected]> >wrote: >> >> This patch enables successful runtime-dependency on the Docker >> preferred provider, as virtual/docker does not resolve. Doing so >> aligns with other virtual package providers (e.g. virtual-runc), and >> follows the Yocto Project documentation >> (https://docs.yoctoproject.org/singleindex.html#virtual-runtime-provides). > >We don't have a virtual-docker rprovides by design. Since there are >differences >(historically) between docker-ce and docker-moby. > >Your package lists and images should be referring to the one they want, not >virtual-docker as a rdepends.
In this case having ` PREFERRED_PROVIDER_virtual/docker ?= "docker-ce"` and ` PROVIDES += "virtual/docker"` is useless? -- Diego > >Bruce > >> >> Signed-off-by: Richard Neill <[email protected]> >> --- >> recipes-containers/docker/docker.inc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/recipes-containers/docker/docker.inc >> b/recipes-containers/docker/docker.inc >> index 40a3642..e196f9b 100644 >> --- a/recipes-containers/docker/docker.inc >> +++ b/recipes-containers/docker/docker.inc >> @@ -32,6 +32,7 @@ RDEPENDS:${PN} += "virtual-containerd virtual-runc" >> RRECOMMENDS:${PN} = "kernel-module-dm-thin-pool kernel-module-nf- >nat kernel-module-nf-conntrack-netlink kernel-module-xt-addrtype kernel- >module-xt-masquerade" >> >> PROVIDES += "virtual/docker" >> +RPROVIDES:${PN} += "virtual-docker" >> >> # we want all the docker variant recpes to be installable via "docker" >> PACKAGE_NAME = "docker" >> -- >> 2.25.1 >> >> >> >> > > >-- >- Thou shalt not follow the NULL pointer, for chaos and madness await thee at >its end >- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#7244): https://lists.yoctoproject.org/g/meta-virtualization/message/7244 Mute This Topic: https://lists.yoctoproject.org/mt/90888043/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
