On Wed, Jul 13, 2022 at 3:29 PM Christopher Clark
<[email protected]> wrote:
>
> On Wed, Jul 13, 2022 at 4:02 AM Ross Burton <[email protected]> wrote:
> >
> > Nothing in Xen respects --enable-sdl, and nothing in Xen links to libSDL,
> > so this PACKAGECONFIG is obsolete.
> >
> > It looks like the last user of SDL in Xen was removed in "Remove
> > internal tools/ioemu tree"[1] back in 2008.
> >
> > [1] xen 19dc3860dcfde9bc4ec4ef35bb1337e13276f630
> >
>
> I was surprised by this but think it is correct.
> There are also no SDL header file inclusions in the Xen tools source,
> and the xen and xen-tools recipes build successfully with this patch
> applied.
>
> > Signed-off-by: Ross Burton <[email protected]>
>
> Reviewed-by: Christopher Clark <[email protected]>
>
Since this is showing up on the yocto autobuilder as well, I've bumped
it up the queue and done the merge.
Bruce
> Christopher
>
>
> > ---
> > recipes-extended/xen/xen.inc | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> > index 2bbf1e3..5937763 100644
> > --- a/recipes-extended/xen/xen.inc
> > +++ b/recipes-extended/xen/xen.inc
> > @@ -7,12 +7,10 @@ inherit autotools-brokensep pkgconfig
> > require xen-arch.inc
> >
> > PACKAGECONFIG ??= " \
> > - sdl \
> > ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} \
> > "
> >
> > PACKAGECONFIG[lzo] = ",,lzo"
> > -PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl,"
> > PACKAGECONFIG[xsm] =
> > "--enable-xsmpolicy,--disable-xsmpolicy,checkpolicy-native,"
> > PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd,"
> > PACKAGECONFIG[externalblktap] = ",,,"
> > --
> > 2.34.1
> >
> >
> >
> >
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#7459):
https://lists.yoctoproject.org/g/meta-virtualization/message/7459
Mute This Topic: https://lists.yoctoproject.org/mt/92354872/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
