On Mon, Jul 18, 2022 at 7:51 AM Anagnostopoulos, Vasileios <[email protected]> wrote: > > Hello Bruce, > > Thank you for merging the changes for the image-oci-umoci in the master > branch! I was wondering, if it makes sense to also back port these changes to > the kirkstone branch? If yes, should I send new patches for the kirkostone > branch? >
I can do cherry picks. the tag change could easily be described as a bug fix (since I did have other tag support already in sloci), the stop signal is technically a "new feature", which I avoid backporting .. but it is a new feature with no ability to impact existing functionality. To summarize the rambling first paragraph, I can cherry pick the two changes to kirkstone :) Bruce > Vasileios > > -----Original Message----- > From: [email protected] > <[email protected]> On Behalf Of Vasileios > Anagnostopoulos via lists.yoctoproject.org > Sent: Thursday, 14 July 2022 08:50 > To: Bruce Ashfield <[email protected]> > Cc: [email protected] > Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent > directory in tar > > Hello Bruce, > > Ok. Thank you for the extra info! Let me know if I can help in any way. > > Vasileios > > -----Original Message----- > From: Bruce Ashfield <[email protected]> > Sent: Wednesday, 13 July 2022 22:37 > To: Anagnostopoulos, Vasileios (SI BP R&D ZG FW ITW) > <[email protected]> > Cc: [email protected] > Subject: Re: [meta-virtualization] [PATCH 3/3] image-oci-umoci: skip parent > directory in tar > > On Wed, Jul 13, 2022 at 3:19 AM Vasileios Anagnostopoulos > <[email protected]> wrote: > > > > Hello Bruce, > > > > How do you generate the images and import them? Could you describe a bit > > more the use case? > > > > With podman for example you can load the image by using `podman load > > -i > > build-oci/tmp/deploy/images/capricorn-64/name-of-the-image-capricorn-6 > > 4-20220713063601.rootfs.tar` > > > > Usually, the tools that support the oci image format also support the > > oci-archive image format. An exception is docker that does not support the > > oci image format and I have first to transform it using skopeo. > > > > What is the advantage of first un-taring the image and then doing the > > import? > > > > There's no advantage, it's just the support for the OCI image format when I > added it, was around the oci image, not the oci-archive, and it was designed > around oci-image-tools, runc, and directly executing / manipulating the > images. The tgz version was something I added after, to make it easier to > copy them around, stage them, and otherwise collect artifacts. docker, > podman or any other specific runtime wasn't the target. > > skopeo was from the beginning the tool that was used to copy/import the > images, and that was with the oci: type .. not with the tarballs .. in those > flows as well. > > I'm just pondering the right way to not break existing layouts and flows, and > that will take me a bit longer. > > > Probably the other 2 patches that I send it with this one > > (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7442&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7C45180cb757f947e2f63008da656510d4%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933782366613603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OnmF%2BmqKwRl0uBfYVswDG7Ko3f62BOMwFyzqQ3zOwjU%3D&reserved=0, > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.yoctoproject.org%2Fg%2Fmeta-virtualization%2Fmessage%2F7441&data=05%7C01%7Cvasileios.anagnostopoulos%40siemens.com%7C45180cb757f947e2f63008da656510d4%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637933782366613603%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bo56q8uJz5WdxSdKh3rzpdw4n9EguCgbgihXmlNPBIM%3D&reserved=0) > > are still relevant, because they are fixing other minor issues. > > > > Yep, I still have those tagged in my "to-review" and "to-test" queues. > > Cheers, > > Bruce > > > > > > > Vasileios > > > > > > > > > > > -- > - Thou shalt not follow the NULL pointer, for chaos and madness await thee at > its end > - "Use the force Harry" - Gandalf, Star Trek II -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#7467): https://lists.yoctoproject.org/g/meta-virtualization/message/7467 Mute This Topic: https://lists.yoctoproject.org/mt/92331697/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
