Hi Chris, On 06/01/2023 08:18, Christopher Clark wrote: > > > > > On Thu, Jan 5, 2023 at 5:54 AM Michal Orzel <[email protected] > <mailto:[email protected]>> wrote: > > Add recipes for xen and tools for the newly released 4.17 version and > take the opportunity to update master recipes. > > > Thanks for taking this on, Michal. > > > > Reflect 4.17 tools changes in xen-tools.inc: > - add test-paging-mempool to test package, > - add a new package init-dom0less that contains init-dom0less script, > > > This tool requires control domain privileges and it depends upon several Xen > libraries including libxl, so would it be better to just include in the > standard xl package, alongside the existing xen-init-dom0? Yes, this would look better to be present next to xen-init-dom0. I will add this into ${PN}-xl.
> > If it does belong in a new separate package, would it make sense for any of > the existing packages to RRECOMMEND it, to ensure that it gets installed > where it is expected to be present? > > > - add localstatedir to dev package. > > > (I've replied to your comment about localstatedir below.) > > > > Signed-off-by: Michal Orzel <[email protected] > <mailto:[email protected]>> > --- > Adding localstatedir to dev package is a little quirk just to keep the old > behavior unchanged and silence Yocto installed-but-not-shipped error. > The reason being, 4.17 onwards removed /var/lib/xenstored as it is mostly > unused. This leaves the build with empty /var and /var/lib. There are > other > possible ways to handle this problem. We could remove the complete > localstatedir > while removing installed volatiles or add some checks for the version. > Suggestions are welcomed. > > > In the same xen-tools.inc file, there is a reference to var-lib-xenstored in > the SYSTEMD_SERVICE declaration for the xencommons package, so: would it make > more sense to add localstatedir to xencommons, which is typically installed > in the control domain, rather than the dev package, which is not? That should > handle the case where there does happen to be a runtime dependency in the Xen > tools on the presence of a /var/lib directory. Sounds good to me. I will add this into ${PN}-xencommons where var-lib-xenstored.mount already is. > > > > --- > recipes-extended/xen/xen-tools.inc | 8 ++++++++ > recipes-extended/xen/xen-tools_4.17.bb > <https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fxen-tools_4.17.bb%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cbcb1629273014bb2320e08daefb64d1b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085863517570625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=M1xgeAw3kTynautLaKMyx07D0ZbwMK2MyODbBzqz1WQ%3D&reserved=0> > | 19 +++++++++++++++++++ > recipes-extended/xen/xen-tools_git.bb > <https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fxen-tools_git.bb%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cbcb1629273014bb2320e08daefb64d1b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085863517570625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6%2F80CN3U7TxiL1oda%2FwqNL6Whbg2ogQDEkCJaRoZL%2BE%3D&reserved=0> > | 8 ++++---- > recipes-extended/xen/xen_4.17.bb > <https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fxen_4.17.bb%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cbcb1629273014bb2320e08daefb64d1b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085863517570625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o5Fa47Bd89zLwAFQDj4ahsnt%2FXOYs9%2F%2BimHJHb7PC0s%3D&reserved=0> > | 19 +++++++++++++++++++ > recipes-extended/xen/xen_git.bb > <https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fxen_git.bb%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cbcb1629273014bb2320e08daefb64d1b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085863517570625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=x0xaDPMAK6HZS2oGP2FRouM6hoA7NZrJMdtVinzhtbg%3D&reserved=0> > | 8 ++++---- > 5 files changed, 54 insertions(+), 8 deletions(-) > create mode 100644 recipes-extended/xen/xen-tools_4.17.bb > <https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fxen-tools_4.17.bb%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cbcb1629273014bb2320e08daefb64d1b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085863517570625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=M1xgeAw3kTynautLaKMyx07D0ZbwMK2MyODbBzqz1WQ%3D&reserved=0> > create mode 100644 recipes-extended/xen/xen_4.17.bb > <https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fxen_4.17.bb%2F&data=05%7C01%7Cmichal.orzel%40amd.com%7Cbcb1629273014bb2320e08daefb64d1b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085863517570625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o5Fa47Bd89zLwAFQDj4ahsnt%2FXOYs9%2F%2BimHJHb7PC0s%3D&reserved=0> > > diff --git a/recipes-extended/xen/xen-tools.inc > b/recipes-extended/xen/xen-tools.inc > index d47309a72b1c..1a422255014e 100644 > --- a/recipes-extended/xen/xen-tools.inc > +++ b/recipes-extended/xen/xen-tools.inc > @@ -212,6 +212,7 @@ PACKAGES = " \ > ${PN}-test \ > ${PN}-xen-vmtrace \ > ${PN}-xen-mceinj \ > + ${PN}-init-dom0less \ > " > > PROVIDES =+ " \ > @@ -245,6 +246,7 @@ FILES:${PN}-dbg += "\ > > FILES:${PN}-dev = "\ > ${includedir} \ > + ${localstatedir} \ > " > > FILES:${PN}-doc = "\ > @@ -688,6 +690,7 @@ FILES:${PN}-test += "\ > ${libdir}/xen/bin/test-resource \ > ${libdir}/xen/bin/test-cpu-policy \ > ${libdir}/xen/bin/test-tsx \ > + ${libdir}/xen/bin/test-paging-mempool \ > " > > # test-xenstore and test-resource currently only exist in 4.16 > @@ -708,6 +711,11 @@ FILES:${PN}-xen-vmtrace +="\ > # xen-vmtrace is only built for x86 4.16, so allow empty package > ALLOW_EMPTY:${PN}-xen-vmtrace = "1" > > +FILES:${PN}-init-dom0less += "${libdir}/xen/bin/init-dom0less" > > > All the existing FILES:${PN} definitions are sorted alphabetically, so when > adding a new one, please could you insert it at the correct point -- which > would be after FILES:${PN}-hvmloader in this case. There will be no need for that as there will be no new package for init-dom0less. > > thanks, > Christopher > I will send a v2 today with the remarks handled. ~Michal
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#7795): https://lists.yoctoproject.org/g/meta-virtualization/message/7795 Mute This Topic: https://lists.yoctoproject.org/mt/96071918/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
