merged.

Bruce

In message: [meta-virtualization][PATCH] libvirt: fix soruce code comments 
contain build folder path cause QA Issue warning
on 18/01/2023 Xiangyu Chen wrote:

> From: Xiangyu Chen <[email protected]>
> 
> gendispatch.pl add build dir in code comments which was generated
> by itself. those build dir information would cause yocto qa report
> warnings like:
> 
> WARNING: libvirt-8.1.0-r0 do_package_qa: QA Issue:
> File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheckqemu.h in 
> package libvirt-src contains reference to TMPDIR
> File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapichecklxc.h in 
> package libvirt-src contains reference to TMPDIR
> File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheckqemu.c in 
> package libvirt-src contains reference to TMPDIR
> File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapichecklxc.c in 
> package libvirt-src contains reference to TMPDIR
> File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheck.h in 
> package libvirt-src contains reference to TMPDIR
> File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheck.c in 
> package libvirt-src contains reference to TMPDIR [buildpaths]
> 
> Signed-off-by: Xiangyu Chen <[email protected]>
> ---
>  ...tch.pl-generating-build-path-in-code.patch | 54 +++++++++++++++++++
>  recipes-extended/libvirt/libvirt_8.1.0.bb     |  1 +
>  2 files changed, 55 insertions(+)
>  create mode 100644 
> recipes-extended/libvirt/libvirt/0001-prevent-gendispatch.pl-generating-build-path-in-code.patch
> 
> diff --git 
> a/recipes-extended/libvirt/libvirt/0001-prevent-gendispatch.pl-generating-build-path-in-code.patch
>  
> b/recipes-extended/libvirt/libvirt/0001-prevent-gendispatch.pl-generating-build-path-in-code.patch
> new file mode 100644
> index 0000000..5a909b4
> --- /dev/null
> +++ 
> b/recipes-extended/libvirt/libvirt/0001-prevent-gendispatch.pl-generating-build-path-in-code.patch
> @@ -0,0 +1,54 @@
> +From ba915b13b92f3a625633ede43789c1ba780371af Mon Sep 17 00:00:00 2001
> +From: Xiangyu Chen <[email protected]>
> +Date: Wed, 18 Jan 2023 03:19:07 +0000
> +Subject: [PATCH] prevent gendispatch.pl generating build path in code 
> comments
> +
> +gendispatch.pl will add build dir in code comments which was generated
> +by itself. those build dir information would cause yocto qa report
> +warnings like:
> +
> +WARNING: libvirt-8.1.0-r0 do_package_qa: 
> +QA Issue: File 
> /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheckqemu.h in package 
> libvirt-src contains reference to TMPDIR
> +File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapichecklxc.h in 
> package libvirt-src contains reference to TMPDIR
> +File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheckqemu.c in 
> package libvirt-src contains reference to TMPDIR
> +File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapichecklxc.c in 
> package libvirt-src contains reference to TMPDIR
> +File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheck.h in 
> package libvirt-src contains reference to TMPDIR
> +File /usr/src/debug/libvirt/8.1.0-r0/src/access/viraccessapicheck.c in 
> package libvirt-src contains reference to TMPDIR [buildpaths]
> +
> +Upstream-Status: Inappropriate [oe specific]
> +
> +Signed-off-by: Xiangyu Chen <[email protected]>
> +---
> + src/rpc/gendispatch.pl | 6 +++---
> + 1 file changed, 3 insertions(+), 3 deletions(-)
> +
> +diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
> +index 9f5bf0e..c73a9dd 100755
> +--- a/src/rpc/gendispatch.pl
> ++++ b/src/rpc/gendispatch.pl
> +@@ -449,19 +449,19 @@ sub hyper_to_long
> + 
> + if ($mode eq "aclsym") {
> +     print <<__EOF__;
> +-# Automatically generated from $protocol by gendispatch.pl.
> ++# Automatically generated by gendispatch.pl.
> + # Do not edit this file.  Any changes you make will be lost.
> + __EOF__
> + } elsif ($mode eq "aclapi") {
> +     print <<__EOF__;
> + <!--
> +-  -  Automatically generated from $protocol by gendispatch.pl.
> ++  -  Automatically generated by gendispatch.pl.
> +   -  Do not edit this file.  Any changes you make will be lost.
> +   -->
> + __EOF__
> + } else {
> +     print <<__EOF__;
> +-/* Automatically generated from $protocol by gendispatch.pl.
> ++/* Automatically generated by gendispatch.pl.
> +  * Do not edit this file.  Any changes you make will be lost.
> +  */
> + __EOF__
> +-- 
> +2.33.1
> +
> diff --git a/recipes-extended/libvirt/libvirt_8.1.0.bb 
> b/recipes-extended/libvirt/libvirt_8.1.0.bb
> index 1de2988..0ffd510 100644
> --- a/recipes-extended/libvirt/libvirt_8.1.0.bb
> +++ b/recipes-extended/libvirt/libvirt_8.1.0.bb
> @@ -29,6 +29,7 @@ SRC_URI = 
> "http://libvirt.org/sources/libvirt-${PV}.tar.xz;name=libvirt \
>             file://hook_support.py \
>             file://gnutls-helper.py \
>             
> file://0001-qemu-segmentation-fault-in-virtqemud-executing-qemuD.patch \
> +           
> file://0001-prevent-gendispatch.pl-generating-build-path-in-code.patch \
>            "
>  
>  SRC_URI[libvirt.sha256sum] = 
> "3c6c43becffeb34a3f397c616206aa69a893ff8bf5e8208393c84e8e75352934"
> -- 
> 2.34.1
> 

> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#7824): 
https://lists.yoctoproject.org/g/meta-virtualization/message/7824
Mute This Topic: https://lists.yoctoproject.org/mt/96348672/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to