In message: [meta-virtualization][PATCH 0/1] lxc: templates/lxc-busybox.in: if 
busybox contains init then use it
on 01/03/2023 Xiangyu Chen wrote:

> From: Xiangyu Chen <[email protected]>
> 
> Hi Bruce,
> 
> Recently we found that the lxc ptest has lots of failure cases as below 
> log-1, after checking the 
> code, some cases failed due to related the init progess. For example, 
> lxc-test-exit-code need to 
> start container as daemon, but if using bash as init, the container cannot 
> start correctly.

Is there an indication of what busybox is providing that bash isn't ?

I don't like to force this in the ptest, while for actual lxc containers
we still allow bash, which means it may not be functional.

There are other init options in meta-virt, like the docker tini, if we
had to enforce something, I'd rather that than busybox.

Bruce

> 
> So added a busybox init utils checking in lxc-busybox template, if current 
> system busybox contains 
> init then use it, after applying this patch, the ptest result as log-2. 
> 
> 
> ######## 1og-1: ptest without patch #######
> 
> Starting LXC ptest ###
> FAIL: lxc-test-api-reboot
> SKIPPED: lxc-test-apparmor
> PASS: lxc-test-apparmor-generated
> FAIL: lxc-test-apparmor-mount
> PASS: lxc-test-arch-parse
> FAIL: lxc-test-attach
> PASS: lxc-test-automount
> FAIL: lxc-test-autostart
> PASS: lxc-test-basic
> FAIL: lxc-test-capabilities
> FAIL: lxc-test-cgpath
> PASS: lxc-test-checkpoint-restore
> FAIL: lxc-test-cloneconfig
> FAIL: lxc-test-clonetest
> FAIL: lxc-test-concurrent
> PASS: lxc-test-config-jump-table
> FAIL: lxc-test-console
> FAIL: lxc-test-console-log
> FAIL: lxc-test-containertests
> FAIL: lxc-test-createconfig
> FAIL: lxc-test-createtest
> PASS: lxc-test-criu-check-feature
> FAIL: lxc-test-cve-2019-5736
> FAIL: lxc-test-destroytest
> FAIL: lxc-test-device-add-remove
> FAIL: lxc-test-exit-code
> FAIL: lxc-test-get_item
> PASS: lxc-test-getkeys
> PASS: lxc-test-list
> PASS: lxc-test-locktests
> FAIL: lxc-test-lxc-attach
> PASS: lxc-test-lxcpath
> PASS: lxc-test-may-control
> FAIL: lxc-test-mount-injection
> FAIL: lxc-test-no-new-privs
> PASS: lxc-test-parse-config-file
> FAIL: lxc-test-proc-pid
> FAIL: lxc-test-procsys
> PASS: lxc-test-raw-clone
> PASS: lxc-test-reboot
> FAIL: lxc-test-rootfs
> FAIL: lxc-test-rootfs-options
> FAIL: lxc-test-saveconfig
> FAIL: lxc-test-share-ns
> FAIL: lxc-test-shortlived
> SKIPPED: lxc-test-shutdowntest
> FAIL: lxc-test-snapdeps
> FAIL: lxc-test-snapshot
> FAIL: lxc-test-startone
> SKIPPED: lxc-test-state-server
> FAIL: lxc-test-symlink
> FAIL: lxc-test-sys-mixed
> FAIL: lxc-test-sysctls
> FAIL: lxc-test-unpriv
> FAIL: lxc-test-usernic
> PASS: lxc-test-usernsexec
> PASS: lxc-test-utils
> 
> 
> 
> 
> 
> Results:
>     PASSED = 17
>     FAILED = 37
>     SKIPPED = 3
> (for details check individual test log in ./logs directory)
> 
> 
> ###########log-2: ptest with patch ###################
> root@intel-x86-64:/usr/lib64/lxc/ptest# ./run-ptest 
> ### Starting LXC ptest ###
> PASS: lxc-test-api-reboot
> SKIPPED: lxc-test-apparmor
> PASS: lxc-test-apparmor-generated
> FAIL: lxc-test-apparmor-mount
> PASS: lxc-test-arch-parse
> PASS: lxc-test-attach
> PASS: lxc-test-automount
> PASS: lxc-test-autostart
> PASS: lxc-test-basic
> PASS: lxc-test-capabilities
> PASS: lxc-test-cgpath
> PASS: lxc-test-checkpoint-restore
> FAIL: lxc-test-cloneconfig
> PASS: lxc-test-clonetest
> PASS: lxc-test-concurrent
> PASS: lxc-test-config-jump-table
> PASS: lxc-test-console
> PASS: lxc-test-console-log
> PASS: lxc-test-containertests
> PASS: lxc-test-createconfig
> PASS: lxc-test-createtest
> PASS: lxc-test-criu-check-feature
> PASS: lxc-test-cve-2019-5736
> PASS: lxc-test-destroytest
> PASS: lxc-test-device-add-remove
> PASS: lxc-test-exit-code
> FAIL: lxc-test-get_item
> PASS: lxc-test-getkeys
> PASS: lxc-test-list
> PASS: lxc-test-locktests
> PASS: lxc-test-lxc-attach
> PASS: lxc-test-lxcpath
> PASS: lxc-test-may-control
> PASS: lxc-test-mount-injection
> FAIL: lxc-test-no-new-privs
> PASS: lxc-test-parse-config-file
> PASS: lxc-test-proc-pid
> PASS: lxc-test-procsys
> PASS: lxc-test-raw-clone
> PASS: lxc-test-reboot
> PASS: lxc-test-rootfs
> PASS: lxc-test-rootfs-options
> PASS: lxc-test-saveconfig
> PASS: lxc-test-share-ns
> PASS: lxc-test-shortlived
> SKIPPED: lxc-test-shutdowntest
> FAIL: lxc-test-snapdeps
> PASS: lxc-test-snapshot
> PASS: lxc-test-startone
> SKIPPED: lxc-test-state-server
> PASS: lxc-test-symlink
> PASS: lxc-test-sys-mixed
> PASS: lxc-test-sysctls
> FAIL: lxc-test-unpriv
> FAIL: lxc-test-usernic
> PASS: lxc-test-usernsexec
> PASS: lxc-test-utils
> 
> Results:
>     PASSED = 47
>     FAILED = 7
>     SKIPPED = 3
> (for details check individual test log in ./logs directory)
> 
> 
> 
> 
> Xiangyu Chen (1):
>   lxc: templates/lxc-busybox.in: if busybox contains init then use it
> 
>  ...box-contains-init-use-it-in-containe.patch | 45 +++++++++++++++++++
>  recipes-containers/lxc/lxc_git.bb             |  1 +
>  2 files changed, 46 insertions(+)
>  create mode 100644 
> recipes-containers/lxc/files/0001-template-if-busybox-contains-init-use-it-in-containe.patch
> 
> -- 
> 2.34.1
> 

> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#7924): 
https://lists.yoctoproject.org/g/meta-virtualization/message/7924
Mute This Topic: https://lists.yoctoproject.org/mt/97306618/21656
Group Owner: [email protected]
Unsubscribe: 
https://lists.yoctoproject.org/g/meta-virtualization/leave/6693005/21656/1014668956/xyzzy
 [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to