On Mon, Mar 6, 2023 at 9:48 PM Yu, Mingli <[email protected]> wrote:
>
> From: Mingli Yu <[email protected]>
>
> Drop {LINKSHARED} to fix the below build failure.
> WARNING:
> /build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/temp/run.do_compile.923432:185
> exit 1 from 'aarch64-wrs-linux-go install -linkshared -p 48 -v -ldflags="-r
> /usr/lib64/go/pkg/linux_arm64_dynlink -I /lib64/ld-linux-aarch64.so.1
> -extldflags ' -mcpu=cortex-a53 -march=armv8-a+crc -fstack-protector-strong
> -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security
> --sysroot=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot
>
> -Wl,-rpath-link=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot/usr/lib64/go/pkg/linux_arm64_dynlink
> -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
>
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/yq-4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
>
> -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
>
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/build=/usr/src/debug/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0
>
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot=
>
> -fmacro-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot=
>
> -fdebug-prefix-map=/build/tmp-glibc/work/cortexa53-wrs-linux/yq/4.30.8+gitdd6cf3df146f3e2c0f8c765a6ef9e35780ad8cc1-r0/recipe-sysroot-native=
> -Wl,-z,relro,-z,now'" -trimpath -buildmode=pie `go_list_packages`'
>
> Before the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 5.2M /usr/bin/yq
>
> After the patch:
> # rpm -ql yq
> /usr
> /usr/bin
> /usr/bin/yq
>
> # du -sh /usr/bin/yq
> 9.0M /usr/bin/yq
>
> Signed-off-by: Mingli Yu <[email protected]>
> ---
> recipes-devtools/yq/yq_git.bb | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
> index 45f2f970..b3e00473 100644
> --- a/recipes-devtools/yq/yq_git.bb
> +++ b/recipes-devtools/yq/yq_git.bb
> @@ -50,6 +50,13 @@ GO_IMPORT = "github.com/mikefarah/yq"
>
> inherit go ptest
>
> +go_do_compile() {
> + export TMPDIR="${GOTMPDIR}"
> + if [ -n "${GO_INSTALL}" ]; then
> + ${GO} install ${GOBUILDFLAGS} `go_list_packages`
> + fi
> +}
My preference is implement do_compile, versus go_do_compile, since the
go.bbclass rarely does the right thing by default.
There's only one other go_do_compile that slipped through my normal
checks (buildah), and I have a local patch removing it, that I'll push
to master-next shortly. buildah also had linkeshared issues :)
Bruce
> +
> do_compile:prepend() {
> # arrange for some of the golang built ins to be found
> (
> --
> 2.25.1
>
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#7930):
https://lists.yoctoproject.org/g/meta-virtualization/message/7930
Mute This Topic: https://lists.yoctoproject.org/mt/97442079/21656
Group Owner: [email protected]
Unsubscribe:
https://lists.yoctoproject.org/g/meta-virtualization/leave/6693005/21656/1014668956/xyzzy
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
