On Tue, May 2, 2023 at 4:48 PM Peter Kjellerstedt
<[email protected]> wrote:
>
> > -----Original Message-----
> > From: Bruce Ashfield <[email protected]>
> > Sent: den 2 maj 2023 22:41
> > To: Peter Kjellerstedt <[email protected]>
> > Cc: [email protected]
> > Subject: Re: [meta-virtualization] [PATCH 4/8] aardvark-dns: Fetch the
> > crate instead of the Git repository
> >
> > On Tue, May 2, 2023 at 4:26 PM Peter Kjellerstedt
> > <[email protected]> wrote:
> > >
> > > Signed-off-by: Peter Kjellerstedt <[email protected]>
> > > ---
> > > recipes-containers/aardvark-dns/aardvark-dns_1.2.0.bb | 8 ++------
> > > 1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/recipes-containers/aardvark-dns/aardvark-dns_1.2.0.bb
> > > b/recipes-containers/aardvark-dns/aardvark-dns_1.2.0.bb
> > > index 10901eb..ac2fc6d 100644
> > > --- a/recipes-containers/aardvark-dns/aardvark-dns_1.2.0.bb
> > > +++ b/recipes-containers/aardvark-dns/aardvark-dns_1.2.0.bb
> > > @@ -4,15 +4,11 @@ HOMEPAGE = "https://github.com/containers/aardvark-dns";
> > > LICENSE = "Apache-2.0"
> > > LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
> > >
> > > -SRCREV = "cb1a462dd8427e33355f6907394a0646f5a26bf2"
> > > -
> > > -# how to get aardvark-dns could be as easy as but default to a git
> > > checkout:
> > > -# SRC_URI += "crate://crates.io/aardvark-dns/1.2.0"
> > > -SRC_URI =
> > > "git://github.com/containers/aardvark-dns;protocol=https;nobranch=1 \
> >
> > I much prefer the git fetch, and am inclined to reject this part of the
> > update.
> >
> > Is something actually broken with the git fetch ? If we can't mix the
> > two, then I'm inclined to say the crates support is broken.
> >
> > Bruce
>
> While this change is not strictly necessary, I was looking for
> some recipe in the common layers to serve as example for how to
> use the crate fetcher to fetch the source for the recipe's source,
> and these two were the only ones I could find that fit the bill.
>
> Be aware that this and the corresponding patch for netavark do
> not work until the functionality in the crate fetcher has been
> restored to support fetching the recipe's code using it (see my
> patch to bitbake-devel from a couple of days ago).
I'm not following the rust and crates discussions too closely, but I
am always a supporter of the revision control history in the source.
As the one who ends up fixing, bumping and otherwise maintaining, I
need that granularity and insist on it when I can.
So in this case, let's leave it as git and from my reading of the
bitbake patches, we shouldn't see the issue as we have no crate
matching the recipe name.
I do appreciate the cleanups, but there are other things I'm putting
as a higher importance (the revision control history).
Perhaps leave the fetch-the-main-source-as-a-crate in the recipe as a comment ?
Bruce
>
> //Peter
>
> >
> > > +SRC_URI = "crate://crates.io/${BPN}/${PV} \
> > > file://run-ptest"
> > > require ${BPN}-crates.inc
> > >
> > > -S = "${WORKDIR}/git"
> > > +SRC_URI[aardvark-dns-1.2.0.sha256sum] =
> > > "1f9d011e5edaa6e0fa055e383bec03a46c9ef35dfa346883aeb5bf86b794a949"
> > >
> > > inherit cargo cargo-update-recipe-crates features_check ptest
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8030):
https://lists.yoctoproject.org/g/meta-virtualization/message/8030
Mute This Topic: https://lists.yoctoproject.org/mt/98647878/21656
Group Owner: [email protected]
Unsubscribe:
https://lists.yoctoproject.org/g/meta-virtualization/leave/6693005/21656/1014668956/xyzzy
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
