On Thu, May 4, 2023 at 2:54 PM Bruce Ashfield <[email protected]>
wrote:
> For my next presenter's gift, I want a regex that doesn't nitpick us
> on capitals and dashes ;)
>
I agree, but now when 99.9% of Upstream-Status have the right formatting
and there is a QA check to keep or improve the percentage, it might be a
step back to loosen the regexp.
Funny that I'm not seeing this, I haven't inhibited the check completely
> yet.
>
I've noticed because I was building kubernetes trying to figure out why in
some builds it fails with:
ERROR: QA Issue: File /usr/bin/kubelet in package lib32-kubelet doesn't
have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
while in some other builds this isn't triggered.
Then I've noticed that since
'make generated_files GO="go"
KUBE_BUILD_PLATFORMS="${HOST_GOOS}/${BUILD_GOARCH}"' was commented out in:
https://git.yoctoproject.org/meta-virtualization/commit/?id=8fcd81741740bd4702db999923160155f26e1f25
a lot of *FLAGS* assignments in do_compile are now unnecessary as the later
just overwrites the BUILD_* values set before, but that doesn't seem to be
the root cause for missing GNU_HASH.
At this point I admit that I've blacklisted kubernetes in my DISTRO as I
don't normally build it and it was just showing up as failure in my bitbake
world builds (similarly as ceph and other fixes I've sent earlier).
And I do have patch-status-noncore in WARN_QA, but after noticing this,
I've used patchreview script from oe-core to quickly check all .patch files
in meta-virtualization - with small tweak from:
https://patchwork.yoctoproject.org/project/oe-core/patch/[email protected]/
to make it as strict as insane.bbclass QA check is.
Cheers,
But my jest / complaint notwithstanding, thanks for the patch, I'll
> queue it shortly.
>
> Bruce
>
> On Thu, May 4, 2023 at 3:29 AM Martin Jansa <[email protected]>
> wrote:
> >
> > Signed-off-by: Martin Jansa <[email protected]>
> > ---
> > .../k3s/k3s/0001-Finding-host-local-in-usr-libexec.patch | 2 +-
> > .../0001-hack-lib-golang.sh-use-CC-from-environment.patch | 2 +-
> > ...1-Should-fix-235-nasty_metachars-was-not-being-returne.patch | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/recipes-containers/k3s/k3s/0001-Finding-host-local-in-usr-libexec.patch
> b/recipes-containers/k3s/k3s/0001-Finding-host-local-in-usr-libexec.patch
> > index 524ac2c..12f9941 100644
> > ---
> a/recipes-containers/k3s/k3s/0001-Finding-host-local-in-usr-libexec.patch
> > +++
> b/recipes-containers/k3s/k3s/0001-Finding-host-local-in-usr-libexec.patch
> > @@ -3,7 +3,7 @@ From: Erik Jansson <[email protected]>
> > Date: Wed, 16 Oct 2019 15:07:48 +0200
> > Subject: [PATCH] Finding host-local in /usr/libexec
> >
> > -Upstream-status: Inappropriate [embedded specific]
> > +Upstream-Status: Inappropriate [embedded specific]
> > Signed-off-by: <[email protected]>
> > ---
> > pkg/agent/config/config.go | 2 +-
> > diff --git
> a/recipes-containers/kubernetes/kubernetes/0001-hack-lib-golang.sh-use-CC-from-environment.patch
> b/recipes-containers/kubernetes/kubernetes/0001-hack-lib-golang.sh-use-CC-from-environment.patch
> > index c81bd1a..15e8ffa 100644
> > ---
> a/recipes-containers/kubernetes/kubernetes/0001-hack-lib-golang.sh-use-CC-from-environment.patch
> > +++
> b/recipes-containers/kubernetes/kubernetes/0001-hack-lib-golang.sh-use-CC-from-environment.patch
> > @@ -5,7 +5,7 @@ Subject: [PATCH 1/2] hack/lib/golang.sh: use CC from
> environment
> >
> > Toolchain tupples differs, especially when using vendor provides ones.
> >
> > -Upstream-status: Inappropriate [embedded specific]
> > +Upstream-Status: Inappropriate [embedded specific]
> > Signed-off-by: Koen Kooi <[email protected]>
> > ---
> > hack/lib/golang.sh | 5 -----
> > diff --git
> a/recipes-extended/nagios/nagios-nrpe/0001-Should-fix-235-nasty_metachars-was-not-being-returne.patch
> b/recipes-extended/nagios/nagios-nrpe/0001-Should-fix-235-nasty_metachars-was-not-being-returne.patch
> > index 7a12e73..fb34c5c 100644
> > ---
> a/recipes-extended/nagios/nagios-nrpe/0001-Should-fix-235-nasty_metachars-was-not-being-returne.patch
> > +++
> b/recipes-extended/nagios/nagios-nrpe/0001-Should-fix-235-nasty_metachars-was-not-being-returne.patch
> > @@ -5,7 +5,7 @@ Subject: [PATCH] Should fix #235 (nasty_metachars was
> not being returned when
> > specified in cfg file
> >
> > CVE: CVE-2020-6581
> > -Upstream Status: Backport [4f7dd1199f1f3f72f9197e8565da339a4a2490b7]
> > +Upstream-Status: Backport [4f7dd1199f1f3f72f9197e8565da339a4a2490b7]
> >
> > Signed-off-by: Sakib Sajal <[email protected]>
> > ---
> > --
> > 2.40.1
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8045):
https://lists.yoctoproject.org/g/meta-virtualization/message/8045
Mute This Topic: https://lists.yoctoproject.org/mt/98679455/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
