On Wed, Aug 16, 2023 at 4:32 AM Erik Schilling <[email protected]> wrote: > > On Wed Aug 16, 2023 at 10:11 AM CEST, Mikko Rapeli wrote: > > Hi, > > > > On Mon, Aug 14, 2023 at 10:04:06AM +0200, Erik Schilling wrote: > > > This adds recipes for the first tagged release of the vhost-device > > > daemons of the rust-vmm project. > > > > > > While the initial release was done for all daemons at the same time, > > > the daemons all have indepentend version numbers and will be released > > > on their own schedules in the future. Therefore, I splitted them into > > > independent recipes. > > > > > > Signed-off-by: Erik Schilling <[email protected]> > > > --- > > > These are a bunch of daemons that implement various vhost-user virtio > > > devices. Currently, they are mostly tested with QEMU, but we are also > > > working on Xen support (most bits are upstream already). > > > --- > > > Changes in v2: > > > - Added README.md to explain generation of dependency .inc files > > > - Link to v1: > > > https://lore.kernel.org/r/[email protected] > > > --- > > > README.md | 14 ++ > > > .../vhost-device/vhost-device-gpio-crates.inc | 184 +++++++++++++++ > > > .../vhost-device/vhost-device-gpio_0.1.0.bb | 20 ++ > > > .../vhost-device/vhost-device-i2c-crates.inc | 126 ++++++++++ > > > .../vhost-device/vhost-device-i2c_0.1.0.bb | 16 ++ > > > .../vhost-device/vhost-device-rng-crates.inc | 158 +++++++++++++ > > > .../vhost-device/vhost-device-rng_0.1.0.bb | 17 ++ > > > .../vhost-device/vhost-device-scsi-crates.inc | 166 +++++++++++++ > > > .../vhost-device/vhost-device-scsi_0.1.0.bb | 16 ++ > > > .../vhost-device/vhost-device-vsock-crates.inc | 258 > > > +++++++++++++++++++++ > > > .../vhost-device/vhost-device-vsock_0.1.0.bb | 16 ++ > > > 11 files changed, 991 insertions(+) > > <snip> > > > +++ b/recipes-extended/vhost-device/vhost-device-gpio_0.1.0.bb > > > @@ -0,0 +1,20 @@ > > > +SUMMARY = "vhost gpio backend device" > > > +DESCRIPTION = "A vhost-user backend that emulates a VirtIO GPIO device" > > > +HOMEPAGE = "https://github.com/rust-vmm/vhost-device"; > > > +LICENSE = "Apache-2.0 | BSD-3-Clause" > > > +LIC_FILES_CHKSUM = "\ > > > + file://LICENSE-APACHE;md5=3b83ef96387f14655fc854ddc3c6bd57 \ > > > + file://LICENSE-BSD-3-Clause;md5=2489db1359f496fff34bd393df63947e \ > > > +" > > > +DEPENDS += "libgpiod" > > > +# libgpiod-sys generates bindings using bindgen, which depends on clang > > > +DEPENDS += "clang-native" > > > > As Richard mentioned on #yocto, this recipe adds a new layer dependency from > > meta-virtualization to meta-clang. This could be documented and test build > > jobs > > changed to include meta-clang, or these recipes could be moved to build > > conditionally > > only when meta-clang is available by moving the recipes to directory > > dynamic-layers/meta-clang/recipes-extended > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1528/steps/23/logs/stdio > > Hm... I guess moving vhost-device-gpio to dynamic-layers/ is the least > invasive option? > > @Bruce: Which option do you prefer? I can draft a patch.
Definitely not a dynamic layer :) Can you expand on the dependency a bit more for me ? I find it odd that libgpiod is in meta-oe, but there's no mention (that I can see) about any clang dependencies. I know very little about the way rust is stitching the bits together. Should libgpod really be in the DEPENDS ? Is libgpiod-sys a clang thing ? And libgpiod is somehow conditionally using it ? Either way, we used to do this same dance with meta-security, and we did that via SKIP_RECIPE. So that's how I'd solve this. But obviously none of the core packagesgroups, etc, in meta-virt can have the vhost* packages if that is the case. Barring that, we add the dependency, if it becomes a widespread use case, it'll end up in core anyway. But I still need to understand this a bit better before I will firmly land one way or the other. Bruce > > > Or how hard is the dependency to clang-native? > > vhost-device-gpio depends on libgpiod which generates the bindings at > build time with bindgen [1]. So it is a hard dependency for that daemon. > The other daemons are fine without it. > > [1] https://github.com/rust-lang/rust-bindgen > > - Erik > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8199): https://lists.yoctoproject.org/g/meta-virtualization/message/8199 Mute This Topic: https://lists.yoctoproject.org/mt/100732863/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/leave/6693005/21656/1014668956/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
