On Tue, Jan 9, 2024 at 4:19 AM Ming Liu <[email protected]> wrote: > > Hi, Bruce: > > Seems podman manage its shell completions inside the code (see this line: > https://github.com/containers/podman/pull/21095/commits/6c4892c8029fd992b4494adb62c535d0f5c5d62d#diff-cf5cc76e70a369c5221f08f29ec0452710af1f4ecd423c162d5b669688416caeR484) > > then it uses "podman completion SHELL-NAME" to get the completion for a > particular shell, so it's not safe to pre-generate a completion outside of > podman source? For instance, if we add a CVE fix or some common bug fixes to > SRC_URI, the completion might be changed and the developers have to be aware > of that and also update completion file. >
That CVE example is quite unlikely .. and I'd suggest we created the issue by packaging the completions in the first case. > And this qemu wrapper way is being used in OE in several recipes, like > python, the qemu-native would be built in most cases if you build a OE image, > so would be no much cost on it? Just my personal options. > I'm quite aware of how and where the wrappers are used. It is still too complex for something as trivial as bash completion generation. I'd suggest you can carry the generation and packaging in a bbappend, and that I can look into alternate ways to generate the completions in the future. Even generating them on-target, in a first boot scenario is preferable (from a maintenance point of view). I also have a podman-native extension locally that could be useful, but doing an emulated arch-specific execution of target podman to generate bash completion outputs (that should NOT be arch specfic, and if they are, we want no part of them) is far too heavy. Bruce > the best, > thank you -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8534): https://lists.yoctoproject.org/g/meta-virtualization/message/8534 Mute This Topic: https://lists.yoctoproject.org/mt/103603296/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/leave/6693005/21656/1014668956/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
