On Tue, Oct 1, 2024 at 3:45 PM Sandeep Gundlupet Raju via lists.yoctoproject.org <[email protected]> wrote: > > > On 9/30/2024 12:43 PM, Bruce Ashfield via lists.yoctoproject.org wrote: > > In message: [meta-virtualization][master][scathgap][PATCH] device-tree: > > Rename EXTRA_OVERLAYS to EXTRA_DT_INCLUDE_FILES > > on 27/09/2024 Sandeep Gundlupet Raju wrote: > > > >> Rename EXTRA_OVERLAYS to EXTRA_DT_INCLUDE_FILES as these variables > >> are renamed in device-tree recipe. > > Which device tree recipe is that ? We should include a link to that > > base recipe in this commit, so that others will know which one we > > are tracking. > > > > I checked meta-virt and OE-core and didn't see any variable renames. > [Sandeep]: device-tree recipe is in meta-xilinx > https://github.com/Xilinx/meta-xilinx/blob/master/meta-xilinx-core/recipes-bsp/device-tree/device-tree.bb
Sure, but my point is that needs to be explained in the commit message, and be resent as a v2 of the patch. Bruce > > > > Other than that, no concerns with this patch. > > > > Bruce > > > >> Signed-off-by: Sandeep Gundlupet Raju <[email protected]> > >> --- > >> .../device-tree/device-tree.bbappend | 20 +++++++++---------- > >> 1 file changed, 10 insertions(+), 10 deletions(-) > >> > >> diff --git > >> a/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend > >> b/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend > >> index e235826..813c08f 100644 > >> --- a/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend > >> +++ b/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend > >> @@ -3,17 +3,17 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/files:" > >> ENABLE_XEN_DTSI ?= "" > >> ENABLE_XEN_QEMU_DTSI ?= "" > >> > >> -XEN_EXTRA_OVERLAYS = "" > >> -XEN_EXTRA_QEMU_OVERLAYS = "" > >> +XEN_EXTRA_DT_INCLUDE_FILES = "" > >> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES = "" > >> > >> -XEN_EXTRA_OVERLAYS:zynqmp = "zynqmp-xen.dtsi" > >> -XEN_EXTRA_QEMU_OVERLAYS:zynqmp = "zynqmp-xen.dtsi zynqmp-xen-qemu.dtsi" > >> +XEN_EXTRA_DT_INCLUDE_FILES:zynqmp = "zynqmp-xen.dtsi" > >> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES:zynqmp = "zynqmp-xen.dtsi > >> zynqmp-xen-qemu.dtsi" > >> > >> -XEN_EXTRA_OVERLAYS:versal = "versal-xen.dtsi" > >> -XEN_EXTRA_QEMU_OVERLAYS:versal = "versal-xen.dtsi versal-xen-qemu.dtsi" > >> +XEN_EXTRA_DT_INCLUDE_FILES:versal = "versal-xen.dtsi" > >> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES:versal = "versal-xen.dtsi > >> versal-xen-qemu.dtsi" > >> > >> -XEN_EXTRA_OVERLAYS:versal-net = "versal-net-xen.dtsi" > >> -XEN_EXTRA_QEMU_OVERLAYS:versal-net = "versal-net-xen.dtsi > >> versal-net-xen-qemu.dtsi" > >> +XEN_EXTRA_DT_INCLUDE_FILES:versal-net = "versal-net-xen.dtsi" > >> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES:versal-net = "versal-net-xen.dtsi > >> versal-net-xen-qemu.dtsi" > >> > >> -EXTRA_OVERLAYS:append = "${@' ${XEN_EXTRA_OVERLAYS}' if > >> d.getVar('ENABLE_XEN_DTSI') == '1' else ''}" > >> -EXTRA_OVERLAYS:append = "${@' ${XEN_EXTRA_QEMU_OVERLAYS}' if > >> d.getVar('ENABLE_XEN_QEMU_DTSI') == '1' else ''}" > >> +EXTRA_DT_INCLUDE_FILES:append = "${@' ${XEN_EXTRA_DT_INCLUDE_FILES}' if > >> d.getVar('ENABLE_XEN_DTSI') == '1' else ''}" > >> +EXTRA_DT_INCLUDE_FILES:append = "${@' ${XEN_EXTRA_QEMU_DT_INCLUDE_FILES}' > >> if d.getVar('ENABLE_XEN_QEMU_DTSI') == '1' else ''}" > >> -- > >> 2.34.1 > >> > >> > >> > >> > > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#8906): https://lists.yoctoproject.org/g/meta-virtualization/message/8906 Mute This Topic: https://lists.yoctoproject.org/mt/108696924/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
