On 12/4/2024 11:35 AM, Bruce Ashfield wrote:


On Wed, Dec 4, 2024 at 1:07 PM Gundlupet Raju, Sandeep <[email protected]> wrote:

    Hi Bruce, Chris,

    Do you have any more comments on patches? If there are no comments
    can
    we get this patches merged?


I haven't reviewed them yet and probably won't until next week.

Generally speaking it isn't wise to attempt to rush a merge, in particular when it has been 5 days with an extended weekend in the middle.
Ok sounds good.

Cheers,

Bruce


    Thanks,

    Sandeep

    On 11/29/2024 3:29 PM, Sandeep Gundlupet Raju via
    lists.yoctoproject.org <http://lists.yoctoproject.org>
    wrote:
    > Changes in v4:
    >     - Fix xen-boot-env.inc by inheriting xen-lauch-config bbclass
    >
    > Changes in v3:
    >     - Rename xen-u-boot-scr-configuration.bbclass to
    xen-launch-config.bbclass
    >       as suggested by Christopher Clark as this is not u-boot
    specific.
    >
    > Changes in V2:
    >     - Rename xen-u-boot-scr.bbclass to
    xen-u-boot-scr-configuration.bbclass
    >     - Add comment in u-boot-xlnx-scr.bbappend to specify where
    BOOTMODE
    >       variable is defined.
    >
    > 1. Add xen-lauch-config.bbclass for generic xen launch config
    >     variables use by any soc devices.
    > 2. Inherit xen-launch-config.bbclass in xen-rpi-u-boot-scr.
    > 3. Move xen variables to xen-boot-env.inc file in xilinx
    >     dynamic layers.
    > 4. Include xen-boot-env if BOOTMODE = "xen" switch is enabled.
    > 5. Add load address to boot.cmd.xen script echo messages.
    > 6. Inherit xen-launch-config bbclass in xen-boot-env.inc.
    > 7. If user brings in their own boot.cmd.xxx file they can just
    >     inherit xen-launch-config bbclass and use the generic
    >     xen boot script variables.
    >
    > Sandeep Gundlupet Raju (6):
    >    xen-launch-config: Add bbclass for xen launch config variables
    >    xen-rpi-u-boot-scr: Inherit xen-launch-config bbclass
    >    xen-boot-env: Move xen variables to inc file
    >    u-boot-xlnx-scr: Include xen-boot-env if BOOTMODE is xen
    >    boot.cmd.xen: Add load address to echo messages
    >    xen-boot-env.inc: Inherit xen-launch-config bbclass
    >
    >   classes-recipe/xen-launch-config.bbclass      | 43
    +++++++++++++++++++
    >   .../xen-rpi-u-boot-scr/files/boot.cmd.xen.in
    <http://boot.cmd.xen.in> | 10 ++---
    >   .../xen-rpi-u-boot-scr/xen-rpi-u-boot-scr.bb
    <http://xen-rpi-u-boot-scr.bb> | 13 +++---
    >   .../u-boot/u-boot-xlnx-scr.bbappend           | 13 +++++-
    >   .../u-boot/u-boot-xlnx-scr/boot.cmd.xen       |  8 ++--
    >   .../recipes-bsp/u-boot/xen-boot-cmd.inc       | 35 ---------------
    >   .../recipes-bsp/u-boot/xen-boot-env.inc       | 31 +++++++++++++
    >   7 files changed, 103 insertions(+), 50 deletions(-)
    >   create mode 100644 classes-recipe/xen-launch-config.bbclass
    >   create mode 100644
    dynamic-layers/xilinx/recipes-bsp/u-boot/xen-boot-env.inc
    >
    >
> >



--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9040): 
https://lists.yoctoproject.org/g/meta-virtualization/message/9040
Mute This Topic: https://lists.yoctoproject.org/mt/109841154/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to