This builds just fine for me.

The update never would have been pushed otherwise.

You'll need to elaborate on your distro and other settings that are
triggering this.

Bruce

On Sun, Feb 9, 2025 at 9:46 PM hongxu via lists.yoctoproject.org
<[email protected]> wrote:

> $ bitbake lib32-nerdctl
> ...
> -buildmode=pie requires external (cgo) linking, but cgo is not enabled
> make: *** [Makefile:63: nerdctl] Error 1
> ...
>
> Get back the patch to allow external specification of build settings and
> rebase to v2.0.2
>
> Signed-off-by: Hongxu Jia <[email protected]>
> ---
>  ...xternal-specification-of-build-setti.patch | 34 +++++++++++--------
>  recipes-containers/nerdctl/nerdctl_git.bb     |  1 +
>  2 files changed, 21 insertions(+), 14 deletions(-)
>
> diff --git
> a/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> b/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> index ca7b3042..a384b9e6 100644
> ---
> a/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> +++
> b/recipes-containers/nerdctl/nerdctl/0001-Makefile-allow-external-specification-of-build-setti.patch
> @@ -1,25 +1,31 @@
> -From 0e6809ea075acd3edf7de197cd4e190ccdad6361 Mon Sep 17 00:00:00 2001
> -From: Bruce Ashfield <[email protected]>
> -Date: Mon, 29 Mar 2021 20:50:47 -0400
> +From d254c922f14ca20d09d5258aa908a1105c6acd73 Mon Sep 17 00:00:00 2001
> +From: Hongxu Jia <[email protected]>
>

You can't change the "from:" in a patch.

Bruce



> +Date: Sun, 9 Feb 2025 21:06:29 +0800
>  Subject: [PATCH] Makefile: allow external specification of build settings
>
>  Upstream-Status: Inappropriate [embedded specific]
>
>  Signed-off-by: Bruce Ashfield <[email protected]>
> +
> +Rebase to v2.0.2
> +Signed-off-by: Hongxu Jia <[email protected]>
>  ---
> - Makefile | 3 ++-
> - 1 file changed, 2 insertions(+), 1 deletion(-)
> + src/import/Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
>
> -Index: nerdctl-v2.0.0-beta.1/src/import/Makefile
> -===================================================================
> ---- nerdctl-v2.0.0-beta.1.orig/src/import/Makefile
> -+++ nerdctl-v2.0.0-beta.1/src/import/Makefile
> -@@ -38,7 +38,7 @@
> +diff --git a/src/import/Makefile b/src/import/Makefile
> +index ae4e18c..eb22f9f 100644
> +--- a/src/import/Makefile
> ++++ b/src/import/Makefile
> +@@ -45,7 +45,7 @@ endif
>
>   GO_BUILD_LDFLAGS ?= -s -w
>   GO_BUILD_FLAGS ?=
> --export GO_BUILD=GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) $(GO) build
> -ldflags "$(GO_BUILD_LDFLAGS) -X $(PACKAGE)/pkg/version.Version=$(VERSION)
> -X $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> -+export GO_BUILD=$(GO) build -ldflags "$(GO_BUILD_LDFLAGS) -X
> $(PACKAGE)/pkg/version.Version=$(VERSION) -X
> $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> +-export GO_BUILD=CGO_ENABLED=0 GOOS=$(GOOS) $(GO) -C $(MAKEFILE_DIR)
> build -ldflags "$(GO_BUILD_LDFLAGS) $(VERBOSE_FLAG) -X
> $(PACKAGE)/pkg/version.Version=$(VERSION) -X
> $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> ++export GO_BUILD=GOOS=$(GOOS) $(GO) -C $(MAKEFILE_DIR) build -ldflags
> "$(GO_BUILD_LDFLAGS) $(VERBOSE_FLAG) -X
> $(PACKAGE)/pkg/version.Version=$(VERSION) -X
> $(PACKAGE)/pkg/version.Revision=$(REVISION)"
> +
> + recursive_wildcard=$(wildcard $1$2) $(foreach e,$(wildcard $1*),$(call
> recursive_wildcard,$e/,$2))
>
> - ifdef VERBOSE
> -       VERBOSE_FLAG := -v
> +--
> +2.34.1
> +
> diff --git a/recipes-containers/nerdctl/nerdctl_git.bb
> b/recipes-containers/nerdctl/nerdctl_git.bb
> index 63b96846..84734c9f 100644
> --- a/recipes-containers/nerdctl/nerdctl_git.bb
> +++ b/recipes-containers/nerdctl/nerdctl_git.bb
> @@ -19,6 +19,7 @@ include src_uri.inc
>
>  # patches and config
>  SRC_URI += " \
> +
> file://0001-Makefile-allow-external-specification-of-build-setti.patch \
>              file://modules.txt \
>             "
>
> --
> 2.34.1
>
>
> 
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9127): 
https://lists.yoctoproject.org/g/meta-virtualization/message/9127
Mute This Topic: https://lists.yoctoproject.org/mt/111096110/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to